[
https://issues.apache.org/jira/browse/VCL-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16758501#comment-16758501
]
ASF subversion and git services commented on VCL-1109:
------------------------------------------------------
Commit cc87c75751764937284d869d929ed9714739fa2b in vcl's branch
refs/heads/VCL-1093 from Josh Thompson
[ https://gitbox.apache.org/repos/asf?p=vcl.git;h=cc87c75 ]
VCL-1109 - date duplicated on statistic graph labels for day after daylight
saving time rolls back
The fix mentioned in VCL-1109 of just adding a value to the label doesn't
really fix the underlying problem and give incorrect values on the graphs. A
better fix was to change the timezone to UTC before doing any date work so that
DST isn't used.
statistics.php: modified getStatGraphDayData, getStatGraphDayConUsersData,
getStatGraphConBladeUserData, and getStatGraphConVMUserData: added a call at
the beginning of each function to get the current timezone, then set the
timezone to UTC; added a call before any returns in each function that sets the
timezone back to was was retreived at the beginning of the function
> date duplicated on statistic graph labels for day after daylight saving time
> rolls back
> ---------------------------------------------------------------------------------------
>
> Key: VCL-1109
> URL: https://issues.apache.org/jira/browse/VCL-1109
> Project: VCL
> Issue Type: Improvement
> Components: web gui (frontend)
> Reporter: Josh Thompson
> Priority: Major
> Fix For: 2.5.1
>
>
> On the statistic graphs, the day that daylight saving time rolls back is
> repeated as the label for the date on the day following it and then all
> labels after that for the graph are off by a day. A simple fix is to add 3600
> seconds to the line that generates the label for the date for each function
> that generates graph points:
> $label = date('m/d/Y', $i + 3600);
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
