[
https://issues.apache.org/jira/browse/VCL-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16845142#comment-16845142
]
ASF subversion and git services commented on VCL-1086:
------------------------------------------------------
Commit aeb81d143d3ed20103c35962db614e9422d7e6ba in vcl's branch
refs/heads/VCL-1116_use_database_hostnames_for_ad_joined_computers from Josh
Thompson
[ https://gitbox.apache.org/repos/asf?p=vcl.git;h=aeb81d1 ]
VCL-1086 - improve modularization of authentication
authentication.php:
-added $authFuncs['local'] array to top of file
-modified getAuthCookieData: changed argument list from ($loginid, $valid) to
($loginid, $authtype, $valid, $shibauthid); added $authtype to data that is
encrypted as 4th item
-modified readAuthCookie: added more checks for cookie being invalid - if
invalid, clear VCLAUTH cookie so user will be redirected back to login screen;
decrypt encrypted data based on new number of parameters
-added getAuthTypeFromAuthCookie
-moved ldapLogin to authmethods/ldapauth.php
-modified localLogin: added 'local' as 2nd argument when calling
getAuthCookieData
-added unauthLocal
itecsauth.php:
-added $authFuncs['itecs'] array to top of file
-added testITECSAuth
-added processITECSAuth
-added unauthITECS
ldapauth.php:
-added $authFuncs['ldap'] array to top of file
-added unauthLDAP
-moved ldapLogin from authentication.php to here
shibauth.php:
-moved login code from vcl/shibauth/index.php to here
-moved logout code from utils.php to here
-added $authFuncs['shibboleth'] array to top of file
-added testShibAuth
-added processShibAuth (mostly stuff from shibauth/index.php)
-added unauthShib (contains stuff from utils.php logout)
-added getShibauthDataByUser
-modified updateShibUser: utilize getShibVar to process data passed in
from Shibboleth
-modified updateShibGroups: added additional attempt to get id from affiliation
table to use a wildcard with $shibaffil if first attempt fails
-added getShibVar
conf-default.php: removed "shibauth/" from example URL for Shibboleth
authentication
utils.php: modified sendHeaders: moved shibboleth logout code to shibauth.php
and updated to use $authFuncs array and $authtype from getAuthTypeFromCookie to
call correct logout functions
shibauth/index.php:
-moved code to authmethods/shibauth.php
-replaced everything with a simple redirect to the main index page; this script
no longer needs to be called - IdP's can redirect straight back to the main
index page now
> improve modularization of authentication
> ----------------------------------------
>
> Key: VCL-1086
> URL: https://issues.apache.org/jira/browse/VCL-1086
> Project: VCL
> Issue Type: Improvement
> Components: web gui (frontend)
> Reporter: Josh Thompson
> Priority: Major
>
> create a class based system of authentication so that each form of
> authentication can implement a defined set of functions
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
