[ https://issues.apache.org/jira/browse/VCL-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17105481#comment-17105481 ]
ASF subversion and git services commented on VCL-1126: ------------------------------------------------------ Commit 32c259983dd48dde0eef50d68795fb0d27ab45a2 in vcl's branch refs/heads/develop from Josh Thompson [ https://gitbox.apache.org/repos/asf?p=vcl.git;h=32c2599 ] VCL-1126 - allocate computer already having specified IP address for server reservations with specified IP OS.pm: modified confirm_fixed_ip_is_available: added $computer_id argument when calling is_ip_assigned_query; added check for assigned computer having specified IP address and if so, skip ping check utils.pm: modified is_ip_assigned_query: added 2nd (optional) argument for a computer ID; if computer ID is passed in, don't include that computer in query results utils.php: -modified isAvailable: added check for any mapped computers already having the requested IP address, and if so, limit mapped computers to just those and set a flag that mapped computers have been limited; at first check for no computers being available if mapped computer flag is set, use -4 return code instead of 0; if mapped computer flag set, skip removing recently reserved computers that may have failed -modified debugIsAvailable: changed message for case 2 to say an unavailable computer has the requested IP instead of stating an overlapping server reservation has the address assigned > allocate computer already having specified IP address for server reservations > with specified IP > ----------------------------------------------------------------------------------------------- > > Key: VCL-1126 > URL: https://issues.apache.org/jira/browse/VCL-1126 > Project: VCL > Issue Type: Improvement > Components: vcld (backend), web gui (frontend) > Reporter: Josh Thompson > Priority: Major > Fix For: 2.6 > > > Server reservations allow users to specify an IP address to be used. > Currently, the web frontend only checks to see if an existing reservation or > management node has the specified IP address assigned. If not, it will allow > the reservation to move forward. The backend currently checks for any > computer having the IP address assigned in the database, and fails the > reservation if one is found. If not found, it tries to ping the IP and fails > the reservation if the ping is responded to. > This improvement will have the frontend check to see if there is a computer > already assigned the IP in the database that the selected image maps to, and > if so, attempts to assign that computer for the new reservation. The backend > will then need to check if the assigned computer currently has the specified > IP address, and if so, skip the ping check. -- This message was sent by Atlassian Jira (v8.3.4#803005)