[ http://issues.apache.org/jira/browse/VELTOOLS-67?page=comments#action_12449797 ] Claude Brisson commented on VELTOOLS-67: ----------------------------------------
Clean implementation. Two things, though : 1. Maybe it's me, but I don't understand at all where you manage to contextualize session scoped tools that are visible in a request. That is, I've got the feeling that visible tools are determinated only using the request that creates the session. I thought this could only be done by putting session scoped tools in a subclass of Map filtering the getter according to the request URI. 2. My addition to the docs was lost with the first patch, so I resubmit it appart (I should have done that at first time). > Patch implementing path-scoped tools > ------------------------------------ > > Key: VELTOOLS-67 > URL: http://issues.apache.org/jira/browse/VELTOOLS-67 > Project: VelocityTools > Issue Type: New Feature > Components: VelocityView > Affects Versions: 1.3 > Environment: all > Reporter: Claude Brisson > Assigned To: Nathan Bubna > Priority: Minor > Fix For: 1.3 > > Attachments: path-scopes.patch, request-path.patch > > > This patch adds two new scopes: > <scope>/some_path/*</scope> is a subset of the request scope restricting the > instantiation of tools to servlet requests having an URI that begins with > /some_path/. > <scope>/some_pathname</scope> is a subset of the request scope restricting > the instantiation of tools to servlet requests whose URI matches exactly > /some_pathname -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
