[ 
https://issues.apache.org/jira/browse/VELTOOLS-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465244
 ] 

Marc Novakowski commented on VELTOOLS-73:
-----------------------------------------

Just a quick comment about the method name - "$esc.http(string)" seems overly 
generic to me and potentially ambiguous, since the HTTP protocol uses many 
types of encodings (URL encoding for the URL, HTML encoding for HTML content, 
etc. etc.)

Perhaps a more accurate name for this method could be $esc.url(string) instead? 
 Or $esc.urlEncode(string)?

> Added $esc.http(string) to allow the encoding of http parameter values
> ----------------------------------------------------------------------
>
>                 Key: VELTOOLS-73
>                 URL: https://issues.apache.org/jira/browse/VELTOOLS-73
>             Project: Velocity Tools
>          Issue Type: New Feature
>          Components: GenericTools
>    Affects Versions: 1.3
>         Environment: all
>            Reporter: Claude Brisson
>         Assigned To: Claude Brisson
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: escape-http.patch
>
>
> Delegates encoding to java.net.URLEncoder(String,"UTF-8").
> $http("Hello here & there") produces "Hello+here+%26+there"

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to