I would prefer if you committed it to the trunk (which is now 1.4-dev) and not create a 1.3 branch just for this. To get this into 1.3, we'd have to turn the 1.3 tag into a branch and check the fix in there. Then i'd have to re-roll the release, re-test it myself, re-upload it, and call for a new vote.
That's a lot of work for something i think can wait for the next version. We can't account for everything a user does, and this is not a situation new to the 1.3 release. There is also a very simple workaround. The user can always use $request.session or $request.getSession(false) to ensure a fresh session. If you're willing to let this wait for the next version, then go ahead and commit the change to the trunk. (And once again, i'm further convinced we need to move to a more httpd-like release process to avoid wasted release effort. :) On 2/5/07, Claude Brisson <[EMAIL PROTECTED]> wrote:
I may have a little commit: IMO the ChainedContext object should not keep a reference to the session, because the session can be created during the merging process of the template (for instance, a request tool may create the session to store in it some cached value). In this case, $session will remain null while the session does exist. My proposal is just to always fetch the session using the request. Shall I commit it now or wait? Claude I'll try to do it today. Le lundi 05 février 2007 à 10:55 -0800, Nathan Bubna a écrit : > No problems new problems have been reported since the release of > 1.3-rc1, and i've made another, more thorough pass through the docs > and build scripts, so i think we are ready to release 1.3 final. > > Changes since VelocityTools 1.3-rc1 are as follow: > > - Improved "publish" target in build.xml > - Added Christopher Schultz to CONTRIBUTORS > - Minor misc doc updates > - Removed all outdated jakarta URLs i could find > - Changed ant scripts to be explicit about compilation source/targets > > There have been no changes to the source code, test code, or examples > since 1.3-rc1. All tests pass successfully, and there are no further > features or fixes expected for VelocityTools 1.3. The test build for > this release is available at: > > http://people.apache.org/~nbubna/velocity/tools/1.3/ > (i would have put it at people.apache.org/builds/velocity/tools/13, > but i don't appear to have the necessary karma, and i don't think it > really matters for a test build.) > > Please download it, try it out, and vote regarding your support for > doing this release: > > [ ] +1 Let's do it > [ ] +0 Have fun; i don't care. > [ ] -0 Not sure about this, but i won't stop you. > [ ] -1 No, because __________________ > > I plan to tally the results and close the vote sometime after Thursday > 11am PST (roughly 72 hours). > > My vote is +1 > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
