[
https://issues.apache.org/jira/browse/VELTOOLS-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12474899
]
Nathan Bubna commented on VELTOOLS-75:
--------------------------------------
My advice would be to always patch against the branch/tag/trunk that you want
the fix to go into. So, if you want the patch to go into the 1.3.x family,
that's fine. Just make some note about it in the comments, so we know. I
can't remember which revision numbers go with which versions. :) Of course, i
(or another committer) may choose to apply the patch (or the spirit of it) to
another branch instead, but it helps to know where the patch was meant to go.
My favorite patches are, of course, those that are against the current trunk.
But that's because i'm lazy and that's the easiest thing for me to use. :)
And to be honest, i probably wouldn't have said anything but thanks if it
weren't for the Sysout line. that's what tipped me off that you didn't really
look over the patch. ;-)
oh, and of course, it is always very appreciated if the patches conform to the
code style of the project. for us that mostly means braces on their own lines
and 4 spaces instead of tab characters. :)
> Add MessageTool.get method that accepts an explicit Locale
> ----------------------------------------------------------
>
> Key: VELTOOLS-75
> URL: https://issues.apache.org/jira/browse/VELTOOLS-75
> Project: Velocity Tools
> Issue Type: Improvement
> Components: VelocityStruts
> Reporter: Christopher Schultz
> Priority: Trivial
> Fix For: 1.4, 1.x, 2.0
>
> Attachments: VELTOOLS-75.diff, VELTOOLS-75a.diff
>
>
> Perhaps this does not come up very often, but sometimes you want to display a
> message in a language that is not the current user's current locale.
> For instance, we are adding multi-language capability to our product, and I
> want to be able to display a list of languages for which the text "Switch to
> [language]" is displayed in the target language, not the user's current
> language (because if they can't read English, it's going to be hard for them
> to read "Switch to Your Language".
> I propose the addition of a getMessage method that allows you to explicitly
> indicate the locale to use.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
