I agree that this is not part of the public API, and i'm ok with the change. However, we need to make sure this is very well-documented, so that those who do more heavy hacking on Velocity get warning of the change.
And, if it's easy/trivial to add a deprecation path, that wouldn't hurt anything. On 3/13/07, Will Glass-Husain <[EMAIL PROTECTED]> wrote:
How so? I moved ParserVisitor back into the node package, where it was in v1.4. Since it's not part of the public API, shouldn't matter. (Am I right?) We got into trouble with this before by moving the Node object, which is part of the Directive API. WILL On 3/13/07, Henning P. Schmiedehausen <[EMAIL PROTECTED]> wrote: > [EMAIL PROTECTED] writes: > > Uhm, while I agree with that patch, you are aware that this is non-backwards compatible? > > >Author: wglass > >Date: Mon Mar 12 23:09:58 2007 > >New Revision: 517553 > > >URL: http://svn.apache.org/viewvc?view=rev&rev=517553 > >Log: > >move ParserVisitor to node package to avoid being overwritten by javacc. > > >Added: > > velocity/engine/trunk/src/java/org/apache/velocity/runtime/parser/node/ParserVisitor.java > > - copied, changed from r517533, velocity/engine/trunk/src/java/org/apache/velocity/runtime/parser/ParserVisitor.java > >Removed: > > Best regards > Henning > > > -- > Henning P. Schmiedehausen -- [EMAIL PROTECTED] | J2EE, Linux, |gls > 91054 Buckenhof, Germany -- +49 9131 506540 | Apache person |eau > Open Source Consulting, Development, Design | Velocity - Turbine guy |rwc > |m k > INTERMETA - Gesellschaft fuer Mehrwertdienste mbH - RG Fuerth, HRB 7350 |a s > Sitz der Gesellschaft: Buckenhof. Geschaeftsfuehrer: Henning Schmiedehausen |n > > "Save the cheerleader. Save the world." > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > -- Forio Business Simulations Will Glass-Husain [EMAIL PROTECTED] www.forio.com --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
