[
https://issues.apache.org/jira/browse/TEXEN-13?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebastian Zarnekow updated TEXEN-13:
------------------------------------
Attachment: GeneratorNotReallyASingleton.patch
Thanks for extracting createGenerator.
However the actual implementation of Generator as a singleton makes it
impossible to successfully work with a subclass.
I attached a patch that allows to inherit from Generator and will not break
existing code. Tests included.
> Generator.parse fails, if the outputfile points to a directory, that does not
> exist.
> ------------------------------------------------------------------------------------
>
> Key: TEXEN-13
> URL: https://issues.apache.org/jira/browse/TEXEN-13
> Project: Texen
> Issue Type: Bug
> Affects Versions: 1.0
> Reporter: Sebastian Zarnekow
> Fix For: 1.1
>
> Attachments: GeneratorNotReallyASingleton.patch
>
>
> The Texentask generates the outputdirectory, if it does not exist, but the
> Generator-Implementation lacks this feature for control templates like the
> following:
> # control.vm
> $generator.parse("myTemplate.vm", "subdirectory/myTemplate.out")
> So either allow subclasses of TexenTask to use another Generator (1), or
> change the implementation of getWriter to allow the Generator to create
> absent directories(2).
> (1)
> line 486:
> Generator generator = createGenerator();
> protected Generator createGenerator() {
> return Generator.getInstance();
> }
> (2)
> public Writer getWriter(final String path, final String encoding) throws
> Exception {
> final File f = new File(path).getParentFile();
> if (!f.exists()) {
> f.mkdirs();
> }
> ..
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
