[ 
https://issues.apache.org/jira/browse/VELOCITY-584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564171#action_12564171
 ] 

Nathan Bubna commented on VELOCITY-584:
---------------------------------------

Yeah, i don't like the idea of doing anything specific for SSIs, since Velocity 
is used *much* more broadly than that.  But i think it would be fine if 
Velocity just ignored any #foo syntax that wasn't #else, #stop, or #end, since 
those are the only directives (and are very special ones) that don't need to be 
followed by a '('.

I dunno how easy it would be to get the parser to do that, but i think it would 
be a good thing to do.  The more "schmoo" that we ignore, the better (IMHO).

> Change the #include directive ignore the SSI version of include
> ---------------------------------------------------------------
>
>                 Key: VELOCITY-584
>                 URL: https://issues.apache.org/jira/browse/VELOCITY-584
>             Project: Velocity
>          Issue Type: Improvement
>          Components: Engine
>    Affects Versions: 1.5
>            Reporter: Tim White
>
> When processing a file that happens to have the SSI version of 'include' in 
> it, the velocity engine breaks.
> There are many cases where we end up with files that contain both, before 
> they are cleaned up.
> <!--#include file="wisdom.inc"-->
> Essentially, if it sees that syntax, it needs to ignore the include.  A 
> suggestion would be to check for any amount of whitespace after the #include, 
> and then "file=".  I don't think that will step on proper Velocity include 
> syntax.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to