[
https://issues.apache.org/jira/browse/VELOCITY-355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jarkko Viinamäki updated VELOCITY-355:
--------------------------------------
Attachment: velocity-1.6-dev-355-perf.patch
Nathan have you checked if this change has any significant impact on
performance?
NodeUtils.tokenLiteral looks a bit heavy and since it is now called in
SimpleNode, it is used in many parsed nodes. If the bug is related to _only_
#literal directive and there's a performance penalty, would it be possible to
modify just Literal.init instead like Will suggested? The fix works if we use a
modified literal() method in Literal class.
Here's a small patch I used to test this.
> lost '#'s inside #literal()/#end
> --------------------------------
>
> Key: VELOCITY-355
> URL: https://issues.apache.org/jira/browse/VELOCITY-355
> Project: Velocity
> Issue Type: Bug
> Components: Engine
> Affects Versions: 1.4
> Environment: Operating System: All
> Platform: All
> Reporter: Geoffrey Lowney
> Fix For: 1.6
>
> Attachments: velocity-1.6-dev-355-perf.patch
>
>
> I am using VTL (with VPP) to customize a portion of a Perl script. Since Perl
> code has a lot of dollar signs, I am using #literal()/#end to prevent Velocity
> from processing most of the file. What I find is that single '#' characters
> that are not followed by alpha text are removed (inside #literal()/#end).
> For example:
> #literal()
> #!/usr/bin/perl
> #end
> becomes:
> !/usr/bin/perl
> I've tried things like escaping the '#' ('\#') but that leaves the backslash
> ('\#!/usr/bin/perl' becomes '\!/usr/bin/perl'). Nothing seems to work.
> I can use a #set to define a variable with the value '#!/usr/bin/perl', but I
> was hoping I would not have to. It also doesn't help with other single #'s in
> the file (like Perl comments). For those I have had to double up the hashes.
> I'd be happy to try patching the Velocity source, but I had trouble making
> heads
> or tails of the parser engine?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
