[ 
https://issues.apache.org/jira/browse/VELOCITY-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627362#action_12627362
 ] 

Adrian Tarau commented on VELOCITY-467:
---------------------------------------

However, I'm still convinced that in this case(and maybe some other cases) I 
would like to be informed when a wrong object is passed to a #foreach. I agree, 
this should be done on the application side, your code should be protected for 
this kind of "failures" - passing wrong types.
Of course, some logging/listeners which can provide support for the application 
to distinguish and take action for this kind of "problems" would be preferable. 
I would really love to see that happening in 1.7.

> Throw more exceptions and log less errors
> -----------------------------------------
>
>                 Key: VELOCITY-467
>                 URL: https://issues.apache.org/jira/browse/VELOCITY-467
>             Project: Velocity
>          Issue Type: Improvement
>          Components: Engine
>    Affects Versions: 1.5 beta1
>            Reporter: Will Glass-Husain
>            Priority: Minor
>             Fix For: 1.6
>
>
> Now that Velocity application exceptions are based on RuntimeException, we 
> have more opportunity to use exceptions to signal application level problems. 
>  I'm particularly concerned about initialization problems that are logged and 
> may be missed.  We need to review all logged error messages and see if it 
> would be more appropriate to throw an exception instead.  Some of these 
> places we may need to leave as is for backwards compatibility reasons.  (e.g. 
> macro in the global macro library doesn't parse properly).
> Llewellyn Falco made a good case for this on the dev list recently:
> http://www.mail-archive.com/[EMAIL PROTECTED]/msg15067.html
> #####
> I still would like to put in my vote that sending error's to the log is an 
> incredibly BAD idea.
> If something is not working, it should be LOUDLY shown as an exception.
> If it is working I don't really need a log.
> The (velocity) log should be there for velocity developers (those programming 
> the actual velocity code) not users.
> I don't ever care to see tomcat's log, I care to see the things I log while 
> in tomcat.
> Most of all, many many many people do not check the log at all, let alone 
> frequently.
> ####

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to