On Wed, Sep 17, 2008 at 11:24 PM, <[EMAIL PROTECTED]> wrote: > Author: nbubna > Date: Wed Sep 17 23:24:13 2008 > New Revision: 696572 > > URL: http://svn.apache.org/viewvc?rev=696572&view=rev > Log: > refactor to bridge the gap between ToolManager and VelocityView with a new > ViewToolManager class for those who need easier tool mgmt in webapps but > don't need VelocityView's template processing or advanced config conventions > > Added: > > velocity/tools/trunk/src/main/java/org/apache/velocity/tools/view/ViewToolManager.java > (with props) > Modified: > > velocity/tools/trunk/src/main/java/org/apache/velocity/tools/ToolContext.java > > velocity/tools/trunk/src/main/java/org/apache/velocity/tools/ToolManager.java > > velocity/tools/trunk/src/main/java/org/apache/velocity/tools/view/ServletUtils.java > > velocity/tools/trunk/src/main/java/org/apache/velocity/tools/view/VelocityView.java > > velocity/tools/trunk/src/main/java/org/apache/velocity/tools/view/VelocityViewFilter.java > > velocity/tools/trunk/src/main/java/org/apache/velocity/tools/view/VelocityViewServlet.java > > velocity/tools/trunk/src/main/java/org/apache/velocity/tools/view/ViewToolContext.java > > velocity/tools/trunk/src/main/java/org/apache/velocity/tools/view/jsp/VelocityViewTag.java
for those paying attention, there are a few breaks in backwards compatibility here: - removed VelocityView.getContext() methods (just use createContext()) - VelocityView.prepareToolboxes has changed to publishToolboxes - VelocityView.prepareContext has changed its signature - ToolContext lost some unneeded and internally unused constructors yes, this means we should probably do either another beta or an RC before releasing 2.0 final. since my past estimates for 2.0 final have proven way off already, it may now be feasible to wait for Velocity 1.6 to be released. the huge benefit there would be for the VelocityViewTag, which could then rely on a properly working StringResourceLoader to cache tag bodies and not reparse them on every request. i'm also considering trying to pull off one more "bridge" refactoring attempt to bring more API conformity between the currently unrelated generic.LinkTool and the view.LinkTool. i would love comments or feedback on any and all of the above. thanks :) --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
