[ 
https://issues.apache.org/jira/browse/VELOCITY-659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659742#action_12659742
 ] 

Byron Foster commented on VELOCITY-659:
---------------------------------------

I reversed out the LogChute changes since I don't want to deal with package 
dependency, and this is a rather obscure API.

I added the changes to VelocityEngine, I didn't know it existed, but I like it.

I wonder if there is going to be a 1.7?  It may be to soon to answer this, but 
I'm thinking probably not.  However, removing Exception from the method 
signatures would not break existing Velocity integrations since all references 
must catch Exception, or fall within a method that throws Exception.

The one caveat to this is that in VelocityEngine I removed throwing 
IOException.  This would break any code that explicitly catches IOException, 
you can beat me up for this, but I doubt anyone is being so selective..   If 
there are any knifes thrown at me I'll change IOException back, otherwise, I'll 
do it for Velocity.java also.  My motives are first to make the Velocity API 
use unchecked exceptions, which seems like there has already been movement in 
this direction.   The second is that in the case of evaluate it seems 
unreasonable to force someone to catch an Exception that may or may not occur 
depending on there usage, for example passing in a StringWriter.   Anyway, 
that's my position, but I know these things have a way generating opinions.




> Remove throwing Exception from method signatures
> ------------------------------------------------
>
>                 Key: VELOCITY-659
>                 URL: https://issues.apache.org/jira/browse/VELOCITY-659
>             Project: Velocity
>          Issue Type: Improvement
>          Components: Engine
>    Affects Versions: 1.7
>            Reporter: Byron Foster
>
> Remove throwing java.lang.Exception from Velocity methods

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to