[
https://issues.apache.org/jira/browse/VELOCITY-665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12662761#action_12662761
]
Byron Foster commented on VELOCITY-665:
---------------------------------------
I'm not getting any test case failures, is Velocity614TestCase failing for you?
The check for VELOCITY-71 was removed because when it was originally added it
was called during VelocimacroProxy init. However, the 1.6 changes, I believe,
moved this check essentially into render (RuntimeMacro.render ->
VelocimacroProxy.init) At render time the macros are fully initialized, so this
check is unnecessary. Unless of course I'm missing something.
> issues.Velocity614TestCase fails because patch for VELOCITY-71 was removed
> --------------------------------------------------------------------------
>
> Key: VELOCITY-665
> URL: https://issues.apache.org/jira/browse/VELOCITY-665
> Project: Velocity
> Issue Type: Bug
> Affects Versions: 1.6.2, 1.7
> Reporter: Jarkko Viinamäki
> Assignee: Byron Foster
>
> In VelocimacroProxy.checkArgs there is no longer check for the validity of
> macro arguments. As a result, Velocity614TestCase fails. I can't see why we
> could remove the macro argument check?
> Otherwise good job on refactoring the init/checkArgs logic. I was thinking
> about the same thing. Now there is no synchronized block overhead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
