[
https://issues.apache.org/jira/browse/VELTOOLS-112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nathan Bubna resolved VELTOOLS-112.
-----------------------------------
Resolution: Won't Fix
No, fillContext was separate in VelocityTools1.4 release and will stay separate
for 2.0 both for backwards compatibility and because i prefer it to be called
before setContentType. The JVM should have no trouble optimizing a "do
nothing" call out.
> Suggestion to move VelocityViewServlet.fillContext into handleRequest
> ---------------------------------------------------------------------
>
> Key: VELTOOLS-112
> URL: https://issues.apache.org/jira/browse/VELTOOLS-112
> Project: Velocity Tools
> Issue Type: Improvement
> Components: VelocityView
> Affects Versions: 2.0
> Reporter: Steve Hale
> Priority: Trivial
>
> If retaining VelocityViewServlet.handleRequest(req, res, ctx), then I would
> suggest moving fillContext(ctx, req) into it rather than leaving it in
> doRequest. This way it saves a "do nothing" method call if handleRequest is
> overridden (which it had to be when extending VelocityServlet) instead of
> overriding fillContext and getTemplate.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
