[ 
https://issues.apache.org/jira/browse/VELOCITY-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12665593#action_12665593
 ] 

Nathan Bubna commented on VELOCITY-668:
---------------------------------------

My "rule of thumb" for the change log is to note it if one of the following are 
true:

a) it has an issue associated with it (like this one), especially when 
committing someone else's patch.
b) when it's a new feature
c) it fixes a user-reported problem
d) it introduces a backward compatibility issue

so, yeah, please put this in the change log.

> Minor performance tweaks based on Findbugs findings
> ---------------------------------------------------
>
>                 Key: VELOCITY-668
>                 URL: https://issues.apache.org/jira/browse/VELOCITY-668
>             Project: Velocity
>          Issue Type: Improvement
>    Affects Versions: 1.7
>            Reporter: Jarkko Viinamäki
>         Attachments: velocity-minor-perf-tweaks.patch
>
>
> Mainly change two inner classes to static inner classes and a few other 
> slight modifications. See the patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to