[ 
https://issues.apache.org/jira/browse/VELOCITY-700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674366#action_12674366
 ] 

Nathan Bubna commented on VELOCITY-700:
---------------------------------------

-1  no labels.  keep VTL simple, please.  it's not java, nor should it be.  the 
ease of teaching it and reading it are important to me.   FYI, i'm also still 
considering vetoing the #foreach( $user in $users index $i ) syntax, since i 
think it is ugly, unclear, and unnecessary.  the more i look at it, the more i 
dislike it. having that syntax in combo with this one would make my eyes water. 
 (please bear with my grumpy bluntness; i like you, i'm just very concerned 
about syntax choices.)

if you really feel it is necessary to control the break level, there is always 
the LoopTool in velocity tools.  yes, that's not that pretty either, but that 
is part of the point of VelocityTools.  keep ugly, but sometimes desirable 
features out of the core.

if you really feel it is important to have some better break control in the 
core, let's discuss other ways.  like perhaps an optional integer argument for 
#break, to indicate how many levels to break out of.   Something like that 
would at least avoid "uglifying" the #foreach syntax, for an unnecessary 
feature.

> Add #foreach keyword to specify #break level
> --------------------------------------------
>
>                 Key: VELOCITY-700
>                 URL: https://issues.apache.org/jira/browse/VELOCITY-700
>             Project: Velocity
>          Issue Type: New Feature
>          Components: Engine
>    Affects Versions: 2.0
>            Reporter: Byron Foster
>
> if the last argument to to the #foreach directive is a word, then that word 
> serves as a label to indicate the break level for the #break directive. Par 
> exemple:
> #foreach($user in $users outer)
>     #foreach($email in $user.emails)
>         #if($email.expired)
>             #break(outer)
>         #end
>     #end
> #end

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to