[ 
https://issues.apache.org/jira/browse/VELOCITY-731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745449#action_12745449
 ] 

Nathan Bubna commented on VELOCITY-731:
---------------------------------------

An embarrassing lapse of memory.  Sorry, Byron.  Yeah, we discussed this 
before.  Clearly we are overdue for a proper solution.  I wish i had done it 
then when i had more time.

Jorgen, if you get to making a patch for this, that would be great.  If not, i 
will eventually get to it.  Things should, in theory, slow down for me a bit in 
a month or two.

> Velocity 1.6 performance is degraded by introduced toString() calls
> -------------------------------------------------------------------
>
>                 Key: VELOCITY-731
>                 URL: https://issues.apache.org/jira/browse/VELOCITY-731
>             Project: Velocity
>          Issue Type: Bug
>          Components: Engine
>    Affects Versions: 1.6
>         Environment: Apache Velocity 1.6.2
>            Reporter: Jörgen Rydenius
>
> As part of VELOCITY-531, r686428 introduced frequent calls to toString() just 
> to check if toString() != null. If toString() implementations are slightly 
> complex, and very frequently executed, these calls will degrade the site 
> performance. Are they at all necessary? What kind of object would use null as 
> a return value for toString()? Is it possible to remove these toString() 
> calls from the velocity code again?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to