[
https://issues.apache.org/jira/browse/VELOCITY-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795634#action_12795634
]
Nathan Bubna commented on VELOCITY-742:
---------------------------------------
It all seems reasonable to me. I imagine there's potential for some
unpredictability in multi-thread situations where one thread removes/loads a
directive while a parser in another thread is getting a directive. But i think
that's acceptable. Ideally people would make very light use of the remove/load
API, and then only when setting things up.
I'm going to go ahead and commit it.
> Easily Add/Remove/Replace Directives Without Cracking Open Velocity Jar
> -----------------------------------------------------------------------
>
> Key: VELOCITY-742
> URL: https://issues.apache.org/jira/browse/VELOCITY-742
> Project: Velocity
> Issue Type: New Feature
> Components: Engine
> Affects Versions: 1.6.2
> Reporter: Tim White
> Priority: Minor
> Attachments: velocity-742.patch
>
>
> There are two use cases that I have for this issue:
> 1) We need to turn off #include in order to parse .html files that include
> SSI directives: <!--#include virtual=""--> (we always use #parse in our
> world, so no loss for #include going away)
> 2) We need to supply our own version of #parse that contains the development
> hooks that I described in a different issue.
> Right now, the only crisp way to do is is to crack open the velocity .jar and
> make these changes, which is very risky, because future developers may
> upgrade to new versions of Velocity and not realize that there are
> customizations and/or not understand how to remake them....not to mention in
> a shared-classpath environment, we don't always have control over which copy
> of the Velocity .jar we're using.
> Ideally, there would be config options like this:
> directive_remove ("#parse", "#include")
> directive_add ("#parse", "com.qwest.velocity.directives.Parse")
> Thanks!
> Tim
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
