[
https://issues.apache.org/jira/browse/VELOCITY-760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858788#action_12858788
]
Malcolm Edgar commented on VELOCITY-760:
----------------------------------------
Agreed this is a bug, just found this recently as well. Note with Connection
Pools this is can be a real problem.
> DataSourceResourceLoader doesn't close PreparedStatements
> ---------------------------------------------------------
>
> Key: VELOCITY-760
> URL: https://issues.apache.org/jira/browse/VELOCITY-760
> Project: Velocity
> Issue Type: Bug
> Components: Engine
> Affects Versions: 1.6.2
> Reporter: Jerome Waibel
>
> DataSourceResourceLoader.java contains this method:
> private ResultSet readData(final Connection conn,
> final String columnNames,
> final String templateName) throws SQLException
> {
> PreparedStatement ps = conn.prepareStatement("SELECT " + columnNames
> + " FROM "+ tableName + " WHERE " + keyColumn + " = ?");
> ps.setString(1, templateName);
> return ps.executeQuery();
> }
> PreparedStatements created in this method never get closed, only the
> resultset returned may eventually be closed later which isn't sufficient for
> releasing all bound resources. In my project this statement leak lead to the
> oracle running out of open cursors (the infamous ORA-01000 error).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
