With pooled connections they are not automatically garbage collected, so leaving prepared statements open can cause issues depending upon the JDBC driver and connection pool.
regards Malcolm Edgar On Wed, May 5, 2010 at 1:04 AM, Claude Brisson <[email protected]> wrote: > I'll add that not closing the prepared statement on the database side > when the PreparedStatement java object is garbage collected looks rather > like a bug of the Oracle JDBC driver... > > > Claude > > On mar., 2010-05-04 at 07:37 -0700, Nathan Bubna wrote: >> Blech. I'm generally hesitant to commit DataSourceResourceLoader >> changes these days, because i'm not set up to test them. And while >> this bug sounds like a significant problem, i don't believe it is a >> new regression in 1.6. Also, it's an optional ResourceLoader, which >> is pluggable, so users who need to work around this don't have to wait >> for a release or do a fully custom Velocity build. They just need to >> put their own patched version in their app and use that. >> >> I'm already stretching myself to get these releases out, as i have >> very little paid time to get them done, and it's easier on me to have >> these things brought up during the test build phase. So, all told, >> i'm still +1 for this release. And technically, until you get your >> CLA in and finalize your committer status, as the release manager, i'm >> not bound to treat a -1 from you as a veto. Of course, etiquette says >> i definitely should and i'll probably feel more generous after i get >> some caffeine, but i'd just like to complain a little here before i >> give in. We voted you in as a committer so we wouldn't have to keep >> committing your patches for you. What's the hang up? >> >> 2010/5/4 Jarkko Viinamäki-2 <[email protected]>: >> > >> > BTW I just noticed that fix for >> > https://issues.apache.org/jira/browse/VELOCITY-760 should be included in >> > this release (and 1.7 also) since it's a critical bug for those who use the >> > DataSourceResourceLoader. >> > >> > Sorry :) >> > >> > >> > >> > Nathan Bubna wrote: >> >> >> >> Ok, it seems worth doing one last bugfix release for 1.6 while i still >> >> have a little steam here. The release candidate is available here: >> >> >> >> http://people.apache.org/~nbubna/velocity/engine/1.6.4/ >> >> >> >> [ ] +1 Let's do it >> >> [ ] +0 Have fun; i don't care. >> >> [ ] -0 Not sure about this, but i won't stop you. >> >> [ ] -1 No, because __________________ >> >> >> >> If we have the necessary votes, i will close the vote Thursday (May >> >> 6), around 9am PST. If not, i'll start nagging, which is oh-so-fun. >> >> If this doesn't pass or get vetoed by two weeks from today, i'll close >> >> the vote anyway. Can't drag this out forever... >> >> >> >> On Tue, Apr 27, 2010 at 3:39 PM, Nathan Bubna <[email protected]> wrote: >> >>> Ok, we have three small, relatively uncommon but serious bug fixes >> >>> since 1.6.3 was released. Rather than wait for a final 1.7 release, >> >>> it seems prudent to also do 1 1.6.4 release (assuming we can get the >> >>> votes :). Here's the test build: >> >>> >> >>> http://people.apache.org/~nbubna/velocity/engine/1.6.4/ >> >>> >> >>> I plan to call for a release vote on Fri (4/30). >> >>> >> >>> (personal note: based on rev 938704 in the 1.6.x branch) >> >>> >> >> >> >> --------------------------------------------------------------------- >> >> To unsubscribe, e-mail: [email protected] >> >> For additional commands, e-mail: [email protected] >> >> >> >> >> >> >> > >> > -- >> > View this message in context: >> > http://old.nabble.com/-VOTE--Velocity-Engine-1.6.4-final-%28GA%29-bugfix-release-tp28437217p28445690.html >> > Sent from the Velocity - Dev mailing list archive at Nabble.com. >> > >> > >> > --------------------------------------------------------------------- >> > To unsubscribe, e-mail: [email protected] >> > For additional commands, e-mail: [email protected] >> > >> > >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
