On Thu, Jul 8, 2010 at 12:33 AM, Antonio Petrelli <[email protected]> wrote: > 2010/7/8 Nathan Bubna <[email protected]>: >>> * The Excalibur dependency has not been removed. >> >> but it should be > > Yes, I forgot to tell it :-D > > Other things that I forgot: > > - 1 - > The test organization is strange: the .java test files are considered > resources, parsed just to substitute two variables in one file, and > then compiled. These variables are pointing to the template and target > directory. > The best thing to do is using to access resources from classpath and > writing to temporary files. If file access is needed on read phase, > they should be copied into a temporary file and then accessed from > there. > A second solution, easier but I don't like it too much, is to create a > .properties file containing these variables and substitute them only > in this file.
Actually, i would prefer to see most of those old tests re-written to be string-based, not file-based and ditch the substitution, if possible. Though, i imagine we'll still need to do something like that to test the FileResourceLoader, most VTL-centric tests should not use external resources. For where we do need to load files, i don't greatly care how it is done. All of these solutions seem acceptable to me, let whoever does the work decide. > - 2 - > Currently the parser code has been generated previously and then > committed into the repository. Probably, the best approach is to > generate it at build time, using the JavaCC Maven plugin. +1 that would be fantastic > Antonio > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
