[ 
https://issues.apache.org/jira/browse/VELOCITY-789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966997#action_12966997
 ] 

Antonio Petrelli commented on VELOCITY-789:
-------------------------------------------

The problem is only Commons Lang, because Commons Collections is not useful 
anymore, because I think Adrian will remove the only class really used: 
ExtendedProperties.

About Commons Lang, at a first glance I noticed that the really needed classes 
are StringEscapeUtils and StringUtils.
But, about StringUtils, we need only "lame" methods (isEmpty, isNotEmpty, 
equals) that can be easily copied into the original StringUtils inside Velocity 
itself.

Now it's time of StringEscapeUtils. It is really useful, with the exception of 
escapeSql, that is pretty lame too (it replaces quotes with two quotes, nothing 
more). This method is problematic since it uses StringUtils.replace, that works 
differently to String.replaceAll (no regex allowed).

So I can try to shade StringEscapeUtils, Entities and UnhandledException, and 
let's see what happens :-)

> Reorganize dependencies in Velocity Engine Core
> -----------------------------------------------
>
>                 Key: VELOCITY-789
>                 URL: https://issues.apache.org/jira/browse/VELOCITY-789
>             Project: Velocity
>          Issue Type: Bug
>            Reporter: Antonio Petrelli
>            Assignee: Antonio Petrelli
>
> Currently Velocity Engine core depends on:
> Commons Lang
> Commons Collections
> Avalon LogKit
> Apache Jakarta ORO
> LogKit and ORO should be removed, as they are obsolete. Commons Lang and 
> Collections should be replaced or shaded.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to