Yeah, send all changes through the passed Configuration and definitely take init() out of RuntimeServices. I don't mind un-overloading init(...) so long as it is legitimate to call init(null) for manual init of the default configuration.
On Mon, Dec 27, 2010 at 1:44 PM, Adrian Tarau <[email protected]> wrote: > Hi all, > > I reached a point in my journey where I need some feedback regarding some > changes that I think it makes sense. > RuntimeServices offers some methods to inject overriding > properties(ExtendedProperties) which are copied in the final configuration > during initialisation. > > I propose the following: > - setProperty, addProperty, cleaPropery should be removed, developers > should change the configuration using the Configuration instance provided > during initialisation. > - init() , init(Properies), init(String) should become init(Configuration) > and it should not be in the RuntimeServices, only exposed in its > implementation RuntimeInstance. > > Any comments? > > PS. Is the runtime reconfiguration of the engine desired(any need for this?) > so I would implement a configuration listener? I would see some benefits > from changing at runtime some of the parameters(adding new global macros > files, parser settings, etc) but it is not that important. > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
