[ 
https://issues.apache.org/jira/browse/VELOCITY-793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12978900#action_12978900
 ] 

Nathan Bubna commented on VELOCITY-793:
---------------------------------------

I agree we should move to Readers in 2.0.  It is, however, only a serious 
change to the API for advanced users, not template writers.  Providing B.C. 
support would be nice, but is certainly not required nor even expected.

> Change ResourceLoader.getResourceStream to getResourceReader
> ------------------------------------------------------------
>
>                 Key: VELOCITY-793
>                 URL: https://issues.apache.org/jira/browse/VELOCITY-793
>             Project: Velocity
>          Issue Type: Wish
>          Components: Engine
>            Reporter: Christopher Schultz
>             Fix For: 2.x
>
>
> It would be nice to use Readers instead of InputStreams for templates.
> Velocity is all about text-based rendering, so the templates are certainly 
> going to be text-based. Using a Reader allows individual readers to determine 
> the character encoding if necessary (say, from a database) and not have 
> another component second-guess them.
> Of course, this is a serious change to the API. We could possible 
> re-implement getResourceStream to read a Reader and provide bytes as 
> backward-compatibility with older client code, but since we're going to 2.0, 
> this would be the time to make breaking changes to the API.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to