[ 
https://issues.apache.org/jira/browse/VELTOOLS-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633614#comment-16633614
 ] 

Nathan Bubna commented on VELTOOLS-143:
---------------------------------------

I never was happy with the complexity of this tool.

30 seconds of re-evaluation (so take this with a grain of salt), makes me think 
this could also be re-written with a "sub-tool" that gathers all the 
params/uris/etc as it goes and then only tries to sort out what things to set 
in an intelligent order when toString() (or some build() method) is finally 
called. That last part could be done using URIBuilder or URI, the main point is 
to delay construction/merging/etc until called for so that the order of the 
calls does not have to be the order of the merging/constructing/etc.

Of course, i have no time to do such things myself... :(

> LinkTool.uri() causes mailto: links to ignore parameters added using param() 
> method
> -----------------------------------------------------------------------------------
>
>                 Key: VELTOOLS-143
>                 URL: https://issues.apache.org/jira/browse/VELTOOLS-143
>             Project: Velocity Tools
>          Issue Type: Bug
>          Components: GenericTools
>    Affects Versions: 2.0
>         Environment: Velocity 1.7, Velocity Tools 2.0
>            Reporter: Christopher Schultz
>            Priority: Minor
>
> This worked in Velocity Tools 1.4.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to