[
https://issues.apache.org/jira/browse/VELOCITY-892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652601#comment-16652601
]
Claude Brisson commented on VELOCITY-892:
-----------------------------------------
I'm not saying that it's complex, neither that it isn't a better design choice.
I just wanted to check that it was worth, because it's painful to have the API
evolve.
Unless we decide to break backward compatibility on the ConversionHandler API.
Keeping BC would mean having a default implementation in the interface for the
new method, and dragging the deprecated one along up to 3.0... so I'm more
inclined to drop BC in this specific case, it should rigorously be a 3.0 but
Velocity 2.0 hasn't been out for very long and it's quite a minor change.
If no one chimes in, that's what I'll do.
> Method arguments conversions should be based on Type instead of Class
> ---------------------------------------------------------------------
>
> Key: VELOCITY-892
> URL: https://issues.apache.org/jira/browse/VELOCITY-892
> Project: Velocity
> Issue Type: Improvement
> Components: Engine
> Affects Versions: 2.0
> Reporter: Thomas Mortagne
> Priority: Major
> Fix For: 2.0
>
>
> I was happy to see that method arguments conversion has been added to 2.0 so
> that I can remove the uberspector we have on XWiki side but unfortunately
> ConversionHandler is limited to classes which is way too restrictive for us
> (for example if the parameter type is List<String> it won't do the same thing
> than if the type is List<Integer>).
> Our uberspector can be found on
> https://github.com/xwiki/xwiki-commons/blob/master/xwiki-commons-core/xwiki-commons-velocity/src/main/java/org/xwiki/velocity/introspection/MethodArgumentsUberspector.java
> to see what we do exactly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org
