[ 
https://issues.apache.org/jira/browse/VELOCITY-892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16654029#comment-16654029
 ] 

Thomas Mortagne edited comment on VELOCITY-892 at 10/17/18 6:43 PM:
--------------------------------------------------------------------

bq. Well, to my mind, whether Velocity is Type-aware

I never suggested that Velocity should not be Type aware.

I'm just saying that there is two different levels:
* provide a custom converter handler
* provide custom converters to the default converter handler

Just trying to make sure that I will be able to cover all XWiki use cases with 
the new APIs provided by Velocity. Since current system is working well I don't 
want to spend a lot of time on refactoring it to break things basically.


was (Author: tmortagne):
bq. Well, to my mind, whether Velocity is Type-aware

I never suggested that Velocity should not be Type aware.

I'm just saying that there is two different levels:
* provide a custom converter handler
* provide custom converters to the default converter handler

> Method arguments conversions should be based on Type instead of Class
> ---------------------------------------------------------------------
>
>                 Key: VELOCITY-892
>                 URL: https://issues.apache.org/jira/browse/VELOCITY-892
>             Project: Velocity
>          Issue Type: Improvement
>          Components: Engine
>    Affects Versions: 2.0
>            Reporter: Thomas Mortagne
>            Priority: Major
>             Fix For: 2.0
>
>
> I was happy to see that method arguments conversion has been added to 2.0 so 
> that I can remove the uberspector we have on XWiki side but unfortunately 
> ConversionHandler is limited to classes which is way too restrictive for us 
> (for example if the parameter type is List<String> it won't do the same thing 
> than if the type is List<Integer>).
> Our uberspector can be found on 
> https://github.com/xwiki/xwiki-commons/blob/master/xwiki-commons-core/xwiki-commons-velocity/src/main/java/org/xwiki/velocity/introspection/MethodArgumentsUberspector.java
>  to see what we do exactly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org

Reply via email to