On 09/03/2019 19:05, Michael Osipov wrote:
Am 2019-03-07 um 01:16 schrieb Claude Brisson:
2.1 RC1 is history, 2.1 RC2 is on its way.

Here is a proposal for the configuration keys refactoring:

https://velocity.apache.org/engine/devel/configuration-property-changes-in-2.1.html


Claude,

I like the proposal a lot. A very neat rework!

Though, look at [1] there are some properties missing like logging, character encoding. Is the new proposal complete in terms of properties?

Well, this page only lists properties which have changed. My plans for the doc is to rather include a complete reference sheet, mentioning deprecated names when there are ones.


For instance, 'input.encoding'  is dangling for me. It should be either a resource loader property or a parser property or somewhere else? ...

Let's rename it "resource.default_encoding", since that's really what it is.

We don't provide yet any resource.loader.default_encoding property, which looks ok to me. The top-level API is like:

  getTemplate(name) -> getTemplate(name, default encoding)
  getTemplate(name, encoding) -> do the work

and it looks sufficient.

[1] https://velocity.apache.org/engine/devel/configuration.html

Michael

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org

Reply via email to