Claude Brisson commented on VELTOOLS-186:

> If this one is shared, shouldn't a listener rather create this instance and 
> not a servlet?

It's a lazy initialization process, the shared view is built the first time it 
is needed. That's fine this way, since a servlet or a filter relying on the 
view cannot do much without it. We should just ensure there's only one attempt.

> What if someone wants to views differently configured?

That's taken in to account. Servlets use the shared view by default but can use 
their own.

> Review shared VelocityView initialization error handling
> --------------------------------------------------------
>                 Key: VELTOOLS-186
>                 URL: https://issues.apache.org/jira/browse/VELTOOLS-186
>             Project: Velocity Tools
>          Issue Type: Bug
>          Components: VelocityView
>    Affects Versions: 3.0
>            Reporter: Claude Brisson
>            Assignee: Claude Brisson
>            Priority: Minor
> When VelocityView instanciation fails (aka throws an unrecoverable 
> exception), it is attempted again as many times as there are servlets or 
> filters relying on it, even when the instance is supposed to be shared.
> The proper behavior would be to somehow mark the shared instance attribute as 
> being  invalid (but not null).

This message was sent by Atlassian Jira

To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org

Reply via email to