[ https://issues.apache.org/jira/browse/VELOCITY-979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claude Brisson closed VELOCITY-979. ----------------------------------- Fix Version/s: 2.4 Resolution: Fixed Should have been fixed by commit e86a2fbf > Performance issue with comparing strings in Velocity > ---------------------------------------------------- > > Key: VELOCITY-979 > URL: https://issues.apache.org/jira/browse/VELOCITY-979 > Project: Velocity > Issue Type: Improvement > Components: Engine > Affects Versions: 2.3 > Reporter: Alex > Priority: Major > Fix For: 2.4 > > > Most Velocity compare expressions eventually use ASTComparisonNode which at > first attempts to treat data types as numbers: > > Boolean result = compareNumbers(left, right); > if (result == null) > { > result = compareNonNumber(left, right); > } > > There is fairly large overhead when attempting to create BigDecimal from > non-numeric strings used in comparison in the DuckType.asNumber: > > if (coerceType) > { > String string = asString(value);// coerce to string > if (string != null) > { > return new BigDecimal(string); > } > } > > The exception is created capturing stack, etc. On large volume of compare > operations it's very visible. > -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org