ct-parker commented on PR #15: URL: https://github.com/apache/velocity-tools/pull/15#issuecomment-2310310542
> I can easily explain why I have immediate closed this out: Before opening a PR for such a high-impact change I would expect a discussion in the JIRA issue about a possible solution for everyone. You just dropping off this PR which solves _your_ problem by changing the code in main leaving _everyone else_ behind which do rely on `javax` namespace for the years to come. This is not acceptable. I totally understand that people including you want to make use of `jakarta` namespace, but this is not the right approach. @ppodgorsek This is zero modernization Velocity, it is merely a namespace change, that's it. > > Make a reasonable proposal and I will have a look at this. I wholeheartedly support the sentiment of @ghueller, @ChristopherSchultz, and @ppodgorsek , and I also understand the perspective of @michael-o in the desire to not break the current API. I have proposed a "yes, and" solution in my related comment on [VELTOOLS-202](https://issues.apache.org/jira/projects/VELTOOLS/issues/VELTOOLS-202) that provides a clean path for **supporting Servlet API 3.0 through 6.0 (inclusively) in the same build**. The Apache FreeMarker team recently took this approach in their update from 2.3.32 to 2.3.33, which **does not break any backwards compatibility** and opens the path for developers who need to use a modern Servlet API in their projects. As demonstrated in their minor version update, they did not consider this to be a major change, as it did not affect any dependent projects. They did, however, consider this to be a Major Priority. See [FREEMARKER-218](https://issues.apache.org/jira/browse/FREEMARKER-218). I have successfully migrated Apache Tiles 3 to Servlet API 6.0 (which relies on this project) and have found that it works perfectly in Tomcat 10.1. I feel that this is a very reasonable approach that cuts through all arguments against providing support for Servlet API 6.0 in velocity-tools-view. In light of this proven solution, I respectfully request that you reopen this issue. I would be happy to work with @michael-o on a PR that works toward this solution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org
