[
https://issues.apache.org/jira/browse/VXQUERY-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14348214#comment-14348214
]
Preston Carman commented on VXQUERY-66:
---------------------------------------
Thanks for the patch. I applied the patch to my branch and it looks good. I
have one request. In the test cases for round-half-to-even, floor and round,
can you pick a single number for all four numeric types. If you look at
ceiling, we use 5.5 and -5.5 to cover both positive and negative decimal cases.
Consider the use cases for the three functions and pick numbers that will cover
the cases you want to test. Our test will be more readable when using the same
numbers for all the numeric types. Feel free to use and add to the numbers in
abs and ceiling.
> fn:round-half-to-even missing
> -----------------------------
>
> Key: VXQUERY-66
> URL: https://issues.apache.org/jira/browse/VXQUERY-66
> Project: VXQuery
> Issue Type: Sub-task
> Reporter: Preston Carman
> Assignee: Preston Carman
> Attachments: numericFunctions.patch, screenshot-1.png, testsPass.png
>
>
> fn:round-half-to-even is the last missing function from the "functions on
> numeric values".
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
