Hi, Because the previous pull request has conflicts with the master branch, I have made a new pull request [1] (I shall close the previous one soon).
Here I have made the changes as suggested by Preston. - As for having the string tag in the key, I think that it should be there because otherwise we have to explicitly insert a ValueTag into the byte array when returning the keys. If the valuetag is already there in the array, we have to only point to it. - All the test cases pass - I think it is ok to have the constant valuetag of object to be simply OBJECT_TAG as it is similar to ELEMENT_NODE_TAG, ATTRIBUTE_NODE_TAG etc. - js:null has to be implemented--JS_NULL_TAG should be added. What should be its valuetag? - Once the js: null has been defined I could return null if item do not exist and test that. [1] https://github.com/apache/vxquery/pull/40 Thank you. Yours sincerely, Riyafa On 17 May 2016 at 08:29, Christina Pavlopoulou <[email protected]> wrote: > Hi, > > I made a pull request with the Array Builder and Pointable and the > corresponding tests implementations in [1]. > > [1] https://github.com/apache/vxquery/pull/39 > > Thank you, > Christina > > > On 05/16/2016 06:24 PM, Preston Carman wrote: > >> I added a few comments. Also, my sequence unit test is now in master, >> so update your branch. >> >> One high level question: >> Did we decide to include the string tag with the object key or leave >> it out? I can see arguments for both. What do you think? >> >> On Mon, May 16, 2016 at 5:10 AM, Riyafa Abdul Hameed >> <[email protected]> wrote: >> >>> Hi, >>> >>> Thank you Preston. I have made a pull request with my implementation and >>> tests[1] >>> >>> [1] https://github.com/apache/vxquery/pull/36 >>> >>> Thanks again. >>> >>> Yours sincerely, >>> Riyafa >>> >>> On 16 May 2016 at 12:46, Till Westmann <[email protected]> wrote: >>> >>> Very nice! I would have said something similar about the structure of the >>>> tests, but providing an example is much better :) >>>> >>>> Cheers, >>>> Till >>>> >>>> >>>> On 15 May 2016, at 14:01, Preston Carman wrote: >>>> >>>> I created a JUnit pointable test example using the SequencePointable and >>>> >>>>> SequenceBuilder [1]. The JUnit test only needs to deal with the output >>>>> from >>>>> builder and the input to the pointable. At this time, you can custom >>>>> make >>>>> the designated object or array (similar to the custom define >>>>> sequences). >>>>> Then confirm the bytes written by the builder are correct by using the >>>>> pointable. You could even add a test that looks directly at the bytes >>>>> created by the builder class. Once these are working, the constructor >>>>> class >>>>> can be created with appropriate tests for its new features. Lets start >>>>> with >>>>> just the basics of testing these two classes: pointable and builder. >>>>> >>>>> If you create a pull request, we can comment on your approaches and >>>>> give >>>>> you feedback. Also, post feedback on my proposed change [1]. >>>>> >>>>> Thanks, >>>>> Preston >>>>> >>>>> [1] https://github.com/apache/vxquery/pull/35 >>>>> >>>>> On Sat, May 14, 2016 at 8:57 PM, christina pavlopoulou < >>>>> [email protected]> >>>>> wrote: >>>>> >>>>> Hello, >>>>> >>>>>> I, also, implemented the ArrayPointable [1] and the ArrayBuilder [2]. >>>>>> Although, I use the same functions as the sequencePointable in the >>>>>> ArrayPointable, I implemented some of them again to give a different >>>>>> name >>>>>> that in my opinion is more suitable. I may be wrong and in that case I >>>>>> can >>>>>> change the names back to the original ones. I am also trying to >>>>>> implement >>>>>> the test cases but as Riyafa said, we don't have the byte >>>>>> representation >>>>>> yet. For this reason, I try to give myself the byte representation >>>>>> but I >>>>>> haven't finished yet the code. Is it correct to give it ourselves or >>>>>> we >>>>>> have to do it in a different way? >>>>>> >>>>>> Thank you, >>>>>> Christina >>>>>> >>>>>> [1] >>>>>> >>>>>> >>>>>> https://github.com/pavlopoul/vxquery/blob/pavlopoulou/order_fix/vxquery-core/src/main/java/org/apache/vxquery/datamodel/accessors/jsonItem/ArrayPointable.java >>>>>> [2] >>>>>> >>>>>> >>>>>> https://github.com/pavlopoul/vxquery/blob/pavlopoulou/order_fix/vxquery-core/src/main/java/org/apache/vxquery/datamodel/builders/jsonItem/ArrayBuilder.java >>>>>> >>>>>> >>>>>> >>>>>> On 5/14/2016 5:38 AM, Riyafa Abdul Hameed wrote: >>>>>> >>>>>> Hi, >>>>>> >>>>>> I have written a tentative implementation of ObjectPointable[1] and >>>>>> ObjectBuilder[2] classes. I would like to test them. But, by writing >>>>>> the >>>>>> Pointable and the Builder classes I have not introduced the byte >>>>>> representation of the object to the system--which has to be done by >>>>>> the >>>>>> Object constructor if I am not mistaken. Both classes (ObjectPointable >>>>>> and >>>>>> ObjectBuilder) use the byte representation of the Object and do not >>>>>> define >>>>>> it. Without implementing the constructor can I test the classes? If so >>>>>> how? >>>>>> I have also checked the SimpleXQueryTest[3] as suggested by Preston, >>>>>> but >>>>>> we >>>>>> should introduce the byte representation to the system before testing >>>>>> as >>>>>> far as I could understand. >>>>>> >>>>>> [1] >>>>>> >>>>>> >>>>>> https://github.com/riyafa/vxquery/blob/riyafa/JSONiq/vxquery-core/src/main/java/org/apache/vxquery/datamodel/accessors/jsonItem/ObjectPointable.java >>>>>> [2] >>>>>> >>>>>> >>>>>> https://github.com/riyafa/vxquery/blob/riyafa/JSONiq/vxquery-core/src/main/java/org/apache/vxquery/datamodel/builders/jsonItem/ObjectBuilder.java >>>>>> [3] >>>>>> >>>>>> >>>>>> https://github.com/apache/vxquery/blob/master/vxquery-core/src/test/java/org/apache/vxquery/xmlquery/query/SimpleXQueryTest.java >>>>>> >>>>>> Thank you. >>>>>> >>>>>> Yours sincerely, >>>>>> Riyafa >>>>>> -- >>>>>> Riyafa Abdul Hameed >>>>>> Undergraduate, University of Moratuwa >>>>>> >>>>>> Email: [email protected] >>>>>> Website: https://riyafa.wordpress.com/ <http://riyafa.wordpress.com/> >>>>>> <http://facebook.com/riyafa.ahf> <http://lk.linkedin.com/in/riyafa> >>>>>> <http://twitter.com/Riyafa1> >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>> -- >>> Riyafa Abdul Hameed >>> Undergraduate, University of Moratuwa >>> >>> Email: [email protected] >>> Website: https://riyafa.wordpress.com/ <http://riyafa.wordpress.com/> >>> <http://facebook.com/riyafa.ahf> <http://lk.linkedin.com/in/riyafa> >>> <http://twitter.com/Riyafa1> >>> >> > -- Riyafa Abdul Hameed Undergraduate, University of Moratuwa Email: [email protected] Website: https://riyafa.wordpress.com/ <http://riyafa.wordpress.com/> <http://facebook.com/riyafa.ahf> <http://lk.linkedin.com/in/riyafa> <http://twitter.com/Riyafa1>
