Generally looks good to me. Added a few comments - mostly about the change in the rat configuration that’s no obvious by looking at diffs. Could you explain what changed?

Cheers,
Till

On 23 Jun 2016, at 18:01, Preston Carman wrote:

Please review my code changes: https://github.com/apache/vxquery/pull/64

I attempted to track down an issue with creating to many files, but I
got side tracked with all the sonar comments on the way. Please take a
look at my changes and give me your feedback.

Thanks
Preston

Reply via email to