Merged. Side note: I merged to of your changes into master. I ended up doing a force push since the second change wanted to be merged before the first change.
On Fri, Jul 1, 2016 at 12:32 AM, Riyafa Abdul Hameed < [email protected]> wrote: > Hi, > > I have made a PR with a single commit[1]. > > [1] https://github.com/apache/vxquery/pull/79 > > Thank you. > > Yours sincerely, > Riyafa > > On 1 July 2016 at 10:13, Preston Carman <[email protected]> wrote: > >> Looks good, thanks. >> >> Sent from my iPhone >> >> On Jun 30, 2016, at 8:14 PM, Riyafa Abdul Hameed <[email protected]> >> wrote: >> >> Hi, >> >> I updated the PR[1] based on the suggestions. Please let me know if it's >> good to be merged. >> >> [1] https://github.com/apache/vxquery/pull/77 >> >> Thank you. >> >> Yours sincerely, >> Riyafa >> >> On 1 July 2016 at 05:40, Riyafa Abdul Hameed <[email protected]> >> wrote: >> >>> Hi again, >>> >>> I have created a PR with a single commit[1]. >>> >>> [1] https://github.com/apache/vxquery/pull/77 >>> >>> Thank you. >>> >>> Yours sincerely, >>> Riyafa >>> >>> On 30 June 2016 at 22:34, Riyafa Abdul Hameed <[email protected]> >>> wrote: >>> >>>> Hi, >>>> >>>> Thank you for the suggestions. I have fixed the issue[1]. Please kindly >>>> review. >>>> >>>> [1] https://github.com/apache/vxquery/pull/74 >>>> >>>> Thank you. >>>> >>>> Yours sincerely, >>>> Riyafa >>>> >>>> On 29 June 2016 at 22:39, Preston Carman <[email protected]> wrote: >>>> >>>>> My first thought involved not changing the runtime evaluator. You >>>>> could make all the changes to the way the query is being translated. In >>>>> the >>>>> translator, wrap the field name arguments with fn:string and fn:data. Take >>>>> a look at XMLQueryTranslater. You will find a function call "data" which >>>>> takes an ILogicalExpression and wraps it with fn:data. You can make a >>>>> similar function for fn:string. Then just use these functions for your >>>>> field name argument construction. >>>>> >>>>> Let me know if you have questions. >>>>> >>>>> On Wed, Jun 29, 2016 at 9:37 AM, Riyafa Abdul Hameed < >>>>> [email protected]> wrote: >>>>> >>>>>> Hi again, >>>>>> >>>>>> I think now that it would be better to reuse the evaluate() method of >>>>>> the CastScalarEvaluatorFactory class rather than that of the >>>>>> FnStringScalarEvaluatorFactory. Shall I move implementation of the >>>>>> evaluate() method of the CastScalarEvaluatorFactory to the FunctionHelper >>>>>> class so that it could be reused? >>>>>> >>>>>> Thanks again. >>>>>> >>>>>> Yours sincerely, >>>>>> Riyafa >>>>>> >>>>>> >>>>>> On 29 June 2016 at 15:01, Riyafa Abdul Hameed < >>>>>> [email protected]> wrote: >>>>>> >>>>>>> Hi, >>>>>>> >>>>>>> In this issue we have to cast the left operand to xs:string after >>>>>>> atomizing it. I would like to reuse the evaluate() method >>>>>>> FnStringScalarEvaluatorFactory for casting strings. Shall I move it's >>>>>>> implementation to the FunctionHelper class so that it could be reused. >>>>>>> >>>>>>> >>>>>>> Thank you. >>>>>>> >>>>>>> Yours sincerely, >>>>>>> Riyafa >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Riyafa Abdul Hameed >>>>>>> Undergraduate, University of Moratuwa >>>>>>> >>>>>>> Email: [email protected] >>>>>>> Website: https://riyafa.wordpress.com/ >>>>>>> <http://riyafa.wordpress.com/> >>>>>>> <http://facebook.com/riyafa.ahf> <http://lk.linkedin.com/in/riyafa> >>>>>>> <http://twitter.com/Riyafa1> >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Riyafa Abdul Hameed >>>>>> Undergraduate, University of Moratuwa >>>>>> >>>>>> Email: [email protected] >>>>>> Website: https://riyafa.wordpress.com/ <http://riyafa.wordpress.com/> >>>>>> <http://facebook.com/riyafa.ahf> <http://lk.linkedin.com/in/riyafa> >>>>>> <http://twitter.com/Riyafa1> >>>>>> >>>>> >>>>> >>>> >>>> >>>> -- >>>> Riyafa Abdul Hameed >>>> Undergraduate, University of Moratuwa >>>> >>>> Email: [email protected] >>>> Website: https://riyafa.wordpress.com/ <http://riyafa.wordpress.com/> >>>> <http://facebook.com/riyafa.ahf> <http://lk.linkedin.com/in/riyafa> >>>> <http://twitter.com/Riyafa1> >>>> >>> >>> >>> >>> -- >>> Riyafa Abdul Hameed >>> Undergraduate, University of Moratuwa >>> >>> Email: [email protected] >>> Website: https://riyafa.wordpress.com/ <http://riyafa.wordpress.com/> >>> <http://facebook.com/riyafa.ahf> <http://lk.linkedin.com/in/riyafa> >>> <http://twitter.com/Riyafa1> >>> >> >> >> >> -- >> Riyafa Abdul Hameed >> Undergraduate, University of Moratuwa >> >> Email: [email protected] >> Website: https://riyafa.wordpress.com/ <http://riyafa.wordpress.com/> >> <http://facebook.com/riyafa.ahf> <http://lk.linkedin.com/in/riyafa> >> <http://twitter.com/Riyafa1> >> >> > > > -- > Riyafa Abdul Hameed > Undergraduate, University of Moratuwa > > Email: [email protected] > Website: https://riyafa.wordpress.com/ <http://riyafa.wordpress.com/> > <http://facebook.com/riyafa.ahf> <http://lk.linkedin.com/in/riyafa> > <http://twitter.com/Riyafa1> >
