Hi, I have created a PR with the suggested changes[1] except for the 3rd suggestions. The implementation of jdm:keys is based on [2] and jn:keys is based on [3].
[1] https://github.com/apache/vxquery/pull/80 [2] http://jsoniq.org/docs/JSONiqExtensionToXQuery/html-single/index.html#idm139680641300880 [3] http://jsoniq.org/docs/JSONiqExtensionToXQuery/html-single/index.html#idm139680622840960 Thank you. Yours sincerely, Riyafa On 2 July 2016 at 00:33, Till Westmann <[email protected]> wrote: > Hi, > > it’s really great to see the object navigation. This is really nice > progress! > > Looking at the commits I saw a few things that don’t seem to be quite > right. > Could you take a look if those can be fixed? > > 1) The return type for jn:null is specified to be xs:string*, that seems > wrong. > 2) The return type jdm:keys is specified to be item(), that seems wrong as > well. > 3) There’s a lot of overlap between jdm:keys and jn:keys. Do we actually > need jdm:keys? > 4) A number of the new tests don’t have a new-line at the end of the file. > Could we add those? > > Cheers, > Till > -- Riyafa Abdul Hameed Undergraduate, University of Moratuwa Email: [email protected] Website: https://riyafa.wordpress.com/ <http://riyafa.wordpress.com/> <http://facebook.com/riyafa.ahf> <http://lk.linkedin.com/in/riyafa> <http://twitter.com/Riyafa1>
