Hi, I have squashed the commits to a PR[1]
[1] https://github.com/apache/vxquery/pull/95 Thank you. Your sincerely, Riyafa On 12 July 2016 at 07:45, Riyafa Abdul Hameed <[email protected]> wrote: > Hi, > > I have made the suggested changes[1]. I have been thinking that if someone > reuses ppool pointables it might cause problems. Now I have changed the > code so that it wouldn't be a problem if someone reuses them. > > [1] https://github.com/apache/vxquery/pull/90 > > Thank you. > > Yours sincerely, > Riyafa > > On 11 July 2016 at 20:39, Till Westmann <[email protected]> wrote: > >> Hi Riyafa, >> >> I would have thought that if you e.g. need new Pointables for every key >> and >> value in an object, that you could get all of those from a pool and return >> them all at the end (to then be re-used when evaluate is called again for >> another object). Why do you think that that wouldn’t work? >> >> Cheers, >> Till >> >> On 11 Jul 2016, at 7:51, Riyafa Abdul Hameed wrote: >> >> > Hi, >> > >> > I don't think a pointable pool could be used because I cannot reuse >> objects >> > with the same reference. >> > >> > Thank you. >> > >> > Yours sincerely, >> > Riyafa >> > >> > On 11 July 2016 at 12:23, Till Westmann <[email protected]> wrote: >> > >> >> Hi Riyafa, >> >> >> >> Just a quick idea, I haven't looked at you most recent change. >> >> If you need a number of pointables that's bigger than 1 but doesn't >> grow >> >> with the number of items processed, you could think about using a >> >> pointable-pool. >> >> Would that work here? >> >> >> >> Cheers, >> >> Till >> >> >> >>> On Jul 10, 2016, at 23:39, Riyafa Abdul Hameed < >> [email protected]> >> >> wrote: >> >>> >> >>> Hi, >> >>> >> >>> I made some of the suggested changes to the PR[1]. But, I don't think >> >> it's >> >>> possible to reuse one pointable for key or value because only the >> >>> references gets stored in the array when I add it to the array of >> >>> pointables. If I reuse the same pointable then the same references >> will >> >> be >> >>> repeated at different locations in the array and would be of no use. I >> >>> can't reuse ObjectPointable because the byte array needs to be >> different >> >>> for each object so that the keys could be compared. Any suggestions >> would >> >>> be highly appreciated. >> >>> >> >>> [1] https://github.com/apache/vxquery/pull/90 >> >>> >> >>> Thank you. >> >>> >> >>> Yours sincerely, >> >>> Riyafa >> >>> >> >>> On 9 July 2016 at 12:22, Riyafa Abdul Hameed <[email protected] >> > >> >>> wrote: >> >>> >> >>>> Hi, >> >>>> >> >>>> I have created a PR with the changes[1] >> >>>> >> >>>> [1] https://github.com/apache/vxquery/pull/90 >> >>>> >> >>>> Thank you. >> >>>> >> >>>> Yours sincerely, >> >>>> Riyafa >> >>>> >> >>>>> On 4 July 2016 at 11:01, Till Westmann <[email protected]> wrote: >> >>>>> >> >>>>> Hi Riyafa, >> >>>>> >> >>>>> yes, I think that a new evaluator is the right approach. I would >> >> probably >> >>>>> call it some thing like SimpleObjectUnionScalarEvaluator as this >> >> describes >> >>>>> pretty well what it does. >> >>>>> The fact that we have a constructor syntax for it seems secondary to >> >> me. >> >>>>> >> >>>>> Cheers, >> >>>>> Till >> >>>>> >> >>>>>> On 3 Jul 2016, at 7:54, Riyafa Abdul Hameed wrote: >> >>>>>> >> >>>>>> Hi, >> >>>>>> >> >>>>>> In order to evaluate Dynamic object construction, can I create a >> new >> >>>>>> DynamicObjectConstructorScalarEvaluator class? This is because it >> >>>>> happens >> >>>>>> to be difficult to evaluate it in the >> ObjectConstructorScalarEvaluator >> >>>>>> class. >> >>>>>> >> >>>>>> Thank you. >> >>>>>> >> >>>>>> Yours sincerely, >> >>>>>> Riyafa >> >>>>>> >> >>>>>> -- >> >>>>>> Riyafa Abdul Hameed >> >>>>>> Undergraduate, University of Moratuwa >> >>>>>> >> >>>>>> Email: [email protected] >> >>>>>> Website: https://riyafa.wordpress.com/ < >> http://riyafa.wordpress.com/> >> >>>>>> <http://facebook.com/riyafa.ahf> < >> http://lk.linkedin.com/in/riyafa> >> >>>>>> <http://twitter.com/Riyafa1> >> >>>> >> >>>> >> >>>> >> >>>> -- >> >>>> Riyafa Abdul Hameed >> >>>> Undergraduate, University of Moratuwa >> >>>> >> >>>> Email: [email protected] >> >>>> Website: https://riyafa.wordpress.com/ <http://riyafa.wordpress.com/ >> > >> >>>> <http://facebook.com/riyafa.ahf> <http://lk.linkedin.com/in/riyafa> >> >>>> <http://twitter.com/Riyafa1> >> >>> >> >>> >> >>> >> >>> -- >> >>> Riyafa Abdul Hameed >> >>> Undergraduate, University of Moratuwa >> >>> >> >>> Email: [email protected] >> >>> Website: https://riyafa.wordpress.com/ <http://riyafa.wordpress.com/> >> >>> <http://facebook.com/riyafa.ahf> <http://lk.linkedin.com/in/riyafa> >> >>> <http://twitter.com/Riyafa1> >> >> >> >> >> > >> > >> > -- >> > Riyafa Abdul Hameed >> > Undergraduate, University of Moratuwa >> > >> > Email: [email protected] >> > Website: https://riyafa.wordpress.com/ <http://riyafa.wordpress.com/> >> > <http://facebook.com/riyafa.ahf> <http://lk.linkedin.com/in/riyafa> >> > <http://twitter.com/Riyafa1> >> > > > > -- > Riyafa Abdul Hameed > Undergraduate, University of Moratuwa > > Email: [email protected] > Website: https://riyafa.wordpress.com/ <http://riyafa.wordpress.com/> > <http://facebook.com/riyafa.ahf> <http://lk.linkedin.com/in/riyafa> > <http://twitter.com/Riyafa1> > -- Riyafa Abdul Hameed Undergraduate, University of Moratuwa Email: [email protected] Website: https://riyafa.wordpress.com/ <http://riyafa.wordpress.com/> <http://facebook.com/riyafa.ahf> <http://lk.linkedin.com/in/riyafa> <http://twitter.com/Riyafa1>
