Hi,

I am not sure how, but the changes in this PR[1] seem to be in master.
Shall I add more test cases and reflect further changes in another PR?

[1] https://github.com/apache/vxquery/pull/106

Thank you.

Yours sincerely,
Riyafa

On 19 July 2016 at 11:44, Riyafa Abdul Hameed <[email protected]>
wrote:

> Hi,
>
> I have made the changes based on suggestions and squashed the commits to a
> single commit[1].
>
> [1] https://github.com/apache/vxquery/pull/106
>
> Thank you.
>
> Yours sincerely,
> Riyafa
>
> On 16 July 2016 at 06:18, Riyafa Abdul Hameed <[email protected]>
> wrote:
>
>> Hi,
>>
>> I have made the changes based on the suggestions[1].
>>
>> [1] https://github.com/apache/vxquery/pull/99
>>
>> Thank you.
>>
>> Yours sincerely,
>> Riyafa
>>
>> On 15 July 2016 at 23:15, Riyafa Abdul Hameed <[email protected]>
>> wrote:
>>
>>> Hi,
>>>
>>> I have made the suggested changes[1] except for not using a tempKey in
>>> addPair() method in SimpleObjectUnionConstructor: tempKey is needed here
>>> because a UTF8StringPointable is needed to be passed to the getValue method
>>> of the ObjectPointable class.
>>>
>>> [1] https://github.com/apache/vxquery/pull/99
>>>
>>> Thank you.
>>>
>>> Yours sincerely,
>>> Riyafa
>>>
>>> On 15 July 2016 at 06:08, Riyafa Abdul Hameed <[email protected]>
>>> wrote:
>>>
>>>> Hi,
>>>>
>>>> I have made a PR with suggested improvements to
>>>> SimpleObjectUnionScalarEvaluator so that it doesn't extend the
>>>> ObjectConstructorScalarEvaluator[1].
>>>>
>>>> [1] https://github.com/apache/vxquery/pull/99
>>>>
>>>> Thank you.
>>>>
>>>> Yours sincerely,
>>>> Riyafa
>>>>
>>>> --
>>>> Riyafa Abdul Hameed
>>>> Undergraduate, University of Moratuwa
>>>>
>>>> Email: [email protected]
>>>> Website: https://riyafa.wordpress.com/ <http://riyafa.wordpress.com/>
>>>> <http://facebook.com/riyafa.ahf>  <http://lk.linkedin.com/in/riyafa>
>>>> <http://twitter.com/Riyafa1>
>>>>
>>>
>>>
>>>
>>> --
>>> Riyafa Abdul Hameed
>>> Undergraduate, University of Moratuwa
>>>
>>> Email: [email protected]
>>> Website: https://riyafa.wordpress.com/ <http://riyafa.wordpress.com/>
>>> <http://facebook.com/riyafa.ahf>  <http://lk.linkedin.com/in/riyafa>
>>> <http://twitter.com/Riyafa1>
>>>
>>
>>
>>
>> --
>> Riyafa Abdul Hameed
>> Undergraduate, University of Moratuwa
>>
>> Email: [email protected]
>> Website: https://riyafa.wordpress.com/ <http://riyafa.wordpress.com/>
>> <http://facebook.com/riyafa.ahf>  <http://lk.linkedin.com/in/riyafa>
>> <http://twitter.com/Riyafa1>
>>
>
>
>
> --
> Riyafa Abdul Hameed
> Undergraduate, University of Moratuwa
>
> Email: [email protected]
> Website: https://riyafa.wordpress.com/ <http://riyafa.wordpress.com/>
> <http://facebook.com/riyafa.ahf>  <http://lk.linkedin.com/in/riyafa>
> <http://twitter.com/Riyafa1>
>



-- 
Riyafa Abdul Hameed
Undergraduate, University of Moratuwa

Email: [email protected]
Website: https://riyafa.wordpress.com/ <http://riyafa.wordpress.com/>
<http://facebook.com/riyafa.ahf>  <http://lk.linkedin.com/in/riyafa>
<http://twitter.com/Riyafa1>

Reply via email to