Hello,

Thank you Riyafa for noticing this mistake. I updated the function [1] based on your comment and I added the query that you suggested and now it works fine.

[1] https://github.com/apache/vxquery/pull/129

Thank you,
Christina

On 7/27/2016 9:21 PM, Riyafa Abdul Hameed wrote:
Hi Christina,

Sorry about reviewing the code too late. But in the class
*LibjnDescendantArraysScalarEvaluatorFactory
*and the method *insideObject, *I think that you have assumed that the
*op.getKeys(tvp)
*returns a StringPointable. But it returns a sequence--a sequence of keys
if more than one key exists and a StringPointable if only one key exists.
Because of this assumption a query like the following throws an exception:



*    libjn:descendant-arrays({"foo": [1,2], "bar":[3,4]})*
Thank you,
Riyafa

On 20 July 2016 at 23:13, christina pavlopoulou <[email protected]> wrote:

Hi,

I created a new pull request in [2] which only has my files along with a
working version of libjn:flatten.

[2] https://github.com/apache/vxquery/pull/113

Thank you,
Christina


On 7/19/2016 5:51 PM, christina pavlopoulou wrote:

Hello,

I edited the pull request in [1] according to your suggestions.

Thank you,
Christina

On 7/18/2016 9:58 PM, christina pavlopoulou wrote:

Hello,

I implemented in [1] the libjn:descendant-arrays along with the suitable
test case

[1] https://github.com/apache/vxquery/pull/105

Thank you,
Christina


---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus





---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus

Reply via email to