Hi, I have squashed the PR[1] for the implementation of libjn:project and libjn:remove-keys.
[1]https://github.com/apache/vxquery/pull/140 Thank you. Yours sincerely, Riyafa On 4 August 2016 at 06:14, Riyafa Abdul Hameed <[email protected]> wrote: > Hi, > > I have updated PR[1] to improve code reuse for libjn:intersect and > libjn:accumulate. > > [1] https://github.com/apache/vxquery/pull/126 > > > Thank you. > > Yours sincerely, > Riyafa > > On 3 August 2016 at 12:18, Riyafa Abdul Hameed <[email protected]> > wrote: > >> Hi, >> >> I have updated PR[1] to improve code reuse. >> >> [1] https://github.com/apache/vxquery/pull/132 >> >> Thank you. >> >> Yours sincerely, >> Riyafa >> >> On 2 August 2016 at 14:34, Riyafa Abdul Hameed <[email protected]> >> wrote: >> >>> Hi, >>> >>> I have kept the PRs for each of the library functions separate. But >>> several of the classes have common code. And some have common code with >>> SimpleObjectUnionScalarEvaluator(I think it is because these are >>> library functions that could be written using the *declare function* >>> syntax). >>> >>> The following pairs have code that could be reused: >>> >>> >>> - libjn:accumulate()[1] and libjn:intersect()[2] >>> - libjn:project()[3] and libjn:remove-keys()[4] >>> - libjn:descendant-objects()[5] and libjn:descendant-pairs()[6] >>> >>> I would like to receive suggestions on how to go about reusing the code >>> for the pairs. >>> >>> >>> - What kind of names to choose for each of the parent class? >>> - Whether to re factor after the code is merged or before? >>> >>> >>> [1] https://github.com/apache/vxquery/pull/126 >>> [2] https://github.com/apache/vxquery/pull/131 >>> [3] https://github.com/apache/vxquery/pull/132 >>> [4] https://github.com/apache/vxquery/pull/133 >>> [5] https://github.com/apache/vxquery/pull/128 >>> [6] https://github.com/apache/vxquery/pull/130 >>> >>> Thank you. >>> >>> Yours sincerely, >>> Riyafa >>> >>> -- >>> Riyafa Abdul Hameed >>> Undergraduate, University of Moratuwa >>> >>> Email: [email protected] >>> Website: https://riyafa.wordpress.com/ <http://riyafa.wordpress.com/> >>> <http://facebook.com/riyafa.ahf> <http://lk.linkedin.com/in/riyafa> >>> <http://twitter.com/Riyafa1> >>> >> >> >> >> -- >> Riyafa Abdul Hameed >> Undergraduate, University of Moratuwa >> >> Email: [email protected] >> Website: https://riyafa.wordpress.com/ <http://riyafa.wordpress.com/> >> <http://facebook.com/riyafa.ahf> <http://lk.linkedin.com/in/riyafa> >> <http://twitter.com/Riyafa1> >> > > > > -- > Riyafa Abdul Hameed > Undergraduate, University of Moratuwa > > Email: [email protected] > Website: https://riyafa.wordpress.com/ <http://riyafa.wordpress.com/> > <http://facebook.com/riyafa.ahf> <http://lk.linkedin.com/in/riyafa> > <http://twitter.com/Riyafa1> > -- Riyafa Abdul Hameed Undergraduate, University of Moratuwa Email: [email protected] Website: https://riyafa.wordpress.com/ <http://riyafa.wordpress.com/> <http://facebook.com/riyafa.ahf> <http://lk.linkedin.com/in/riyafa> <http://twitter.com/Riyafa1>
