[
https://issues.apache.org/jira/browse/VXQUERY-227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15424494#comment-15424494
]
Riyafa Abdul Hameed edited comment on VXQUERY-227 at 8/17/16 1:20 PM:
----------------------------------------------------------------------
Should the implementation of the getkeys method also take an IPointable as an
argument together with the IMutableValueStorage or should it take only the
IMutableValueStorage as the argument?
I mean should the implementation be getKeys(IPointable p, IMutableValueStorage
mvs) or should it be just getKeys(IMutableValueStorage mvs) ?
was (Author: riyafa abdul hameed):
Should the implementation of the getkeys method also take an IPointable as an
argument together with the IMutableStorage or should it take only the
IMutableStorage as the argument?
I mean should the implementation be getKeys(IPointable p, IMutableStorage mvs)
or should it be just getKeys(IMutableStorage mvs) ?
> Refactor ObjectPointable.getKeys()
> ----------------------------------
>
> Key: VXQUERY-227
> URL: https://issues.apache.org/jira/browse/VXQUERY-227
> Project: VXQuery
> Issue Type: Task
> Reporter: Till
> Assignee: Riyafa Abdul Hameed
>
> ObjectPointable.getKeys() currently takes an IPointable as a parameter. When
> calling getKeys() a sequence of keys will be created in storage that is owned
> by the ObjectPointable and the caller will receive the pointable to that
> storage. In many cases the call will then copy that content of the storage to
> another place.
> Instead of this approach, we should change the interface of getKeys in a way
> that the caller will provide the storage to put the keys in so that a) the
> storage is owned by the caller and b) no additional copy is necessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
