[ 
https://issues.apache.org/jira/browse/VXQUERY-227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15425306#comment-15425306
 ] 

Till commented on VXQUERY-227:
------------------------------

I think that {{getKeys(IMutableValueStorage mvs)}} should be sufficient. Any 
Pointable can then be set easily to that {{IMutableValueStorage}}.
You could start by factoring a method out that works on the 
{{IMutableValueStorage}} and them implement the current {{getKeys(IPointable)}} 
on top of that.
Then you could go through the consumers of {{getKeys}} and migrate them one by 
one (and find out if there are reasons why the new interface might no work that 
well .. one never knows :) ).

> Refactor ObjectPointable.getKeys()
> ----------------------------------
>
>                 Key: VXQUERY-227
>                 URL: https://issues.apache.org/jira/browse/VXQUERY-227
>             Project: VXQuery
>          Issue Type: Task
>            Reporter: Till
>            Assignee: Riyafa Abdul Hameed
>
> ObjectPointable.getKeys() currently takes an IPointable as a parameter. When 
> calling getKeys() a sequence of keys will be created in storage that is owned 
> by the ObjectPointable and the caller will receive the pointable to that 
> storage. In many cases the call will then copy that content of the storage to 
> another place. 
> Instead of this approach, we should change the interface of getKeys in a way 
> that the caller will provide the storage to put the keys in so that a) the 
> storage is owned by the caller and b) no additional copy is necessary.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to