Hi Riyafa,

yes, I think that that would make sense. The idea is that one would have a pool of reusable ArrayBackedValueStores. Each of those would probably grow for a while up to the maximum size that is needed for the evaluation of an operator/function in a plan. And one the maximum size is reached, the stores are re-used until the end of the evaluation without requiring additional allocation or garbage collection.

Cheers,
Till

On 18 Aug 2016, at 18:33, Riyafa Abdul Hameed wrote:

Hi,

Regarding the suggestions on the PR[1], currently there's only a
PointablePooleFactory. Am I to create an
ArrayBackedValueStoragesPoolFactory?

[1] https://github.com/apache/vxquery/pull/147

Thank you.
Yours sincerely,
Riyafa


On 18 August 2016 at 19:15, Riyafa Abdul Hameed <[email protected]>
wrote:

Hi,

I have created a PR[1] to resolve the issue. Please kindly review.

Thank you.

Yours sincerely,
Riyafa

[1] https://github.com/apache/vxquery/pull/147

On 17 August 2016 at 22:17, Riyafa Abdul Hameed <[email protected]>
wrote:

Hi,

As I have commented on the issue VXQUERY-227[1] I would like to know what
the method signature should be?

"Should the implementation of the getkeys method also take an IPointable as an argument together with the IMutableValueStorage or should it take
only the IMutableValueStorage as the argument?
I mean should the implementation be getKeys(IPointable p,
IMutableValueStorage mvs) or should it be just getKeys(IMutableValueStorage
mvs) ?"

Thank you.
Yours sincerely,
Riyafa

[1] https://issues.apache.org/jira/browse/VXQUERY-227?page=com.
atlassian.jira.plugin.system.issuetabpanels:comment-tabpane
l&focusedCommentId=15424494#comment-15424494

--
Riyafa Abdul Hameed
Undergraduate, University of Moratuwa

Email: [email protected]
Website: https://riyafa.wordpress.com/ <http://riyafa.wordpress.com/>
<http://facebook.com/riyafa.ahf>  <http://lk.linkedin.com/in/riyafa>
<http://twitter.com/Riyafa1>




--
Riyafa Abdul Hameed
Undergraduate, University of Moratuwa

Email: [email protected]
Website: https://riyafa.wordpress.com/ <http://riyafa.wordpress.com/>
<http://facebook.com/riyafa.ahf>  <http://lk.linkedin.com/in/riyafa>
<http://twitter.com/Riyafa1>




--
Riyafa Abdul Hameed
Undergraduate, University of Moratuwa

Email: [email protected]
Website: https://riyafa.wordpress.com/ <http://riyafa.wordpress.com/>
<http://facebook.com/riyafa.ahf>  <http://lk.linkedin.com/in/riyafa>
<http://twitter.com/Riyafa1>

Reply via email to