Thanks for the support in getting the test suite working for errors. The fix allowed many of the remaining issues to be resolved. I have now finished the update to 0.3.0. Both indexing and JSONiq are working in the current PR [1]. Please let me know if you have any additional feedback.
All tests are passing on my local machine, but Jenkins is showing two tests failing. The timezone issue has existed for a while and is not new to this update [3]. The other issue I think is related to a test not recognizing the SystemException. Not sure if we should address this now or just file an issue. In addition, I tried looking at 0.3.1 update. We have several issues with changes to classes (new they use get/set methods over public variables) that would need to be resolved to get 0.3.1 working. I am tired of working on updates so that will have to wait or be done by someone else. Thoughts on pushing this version of the code on Hyracks 0.3.0 with 2 known errors to master? [1] https://github.com/apache/vxquery/pull/166 [2] https://asterix-jenkins.ics.uci.edu/job/vxquery-pr/405/ [3] https://issues.apache.org/jira/browse/VXQUERY-239 On Sat, Apr 22, 2017 at 9:35 PM, Till Westmann <[email protected]> wrote: > Hi, > > I’ve a added a few comments to the PR. > > On 1, I think that what I saw was fine wrt the current Hyracks APIs, but I’m > not sure that I like the current Hyracks APIs :) > > On 2, we have 2 issues: > a) Hyracks exceptions do not contain that exception class in the exception > message anymore. This can be easily solved by adapting > TestRunner.EMBEDDED_SYSERROR_PATTERN to be > "(\\p{javaUpperCase}{4}\\d{4})". > b) The bigger issue is, that there are recent changes in the Hyracks result > distribution that make the delivery of exceptions less reliable and we > seem to hit that quite often. As I think that I was the last to work on > that, I probably introduced this issue:( > As a workaround, we can check that the result status before reading the > result, but the real fix needs to be in Hyracks … > > Cheers, > Till > > > On 19 Apr 2017, at 15:58, Till Westmann wrote: > >> Hi Preston, >> >> thanks for doing this! >> >> I think that I can take a look at points 1 and 2, but probably not before >> the weekend. >> >> For point 3 I think that mini dfs is part of regular hadoop, so this might >> just be a maven dependency (unless we have our own wrapper). Probably Ian >> could answer the question with a single look at the code in question. >> >> Cheers, >> Till >> >> >> On 19 Apr 2017, at 15:05, Preston Carman wrote: >> >>> I started working on a branch for going to Hyracks 0.3.0 [1]. The >>> process was a lot more involved than I expected. We have two larger >>> changes: error handling and UTF8StringPointable storage format change. >>> I have a few questions and could use some help in getting this upgrade >>> ready. >>> >>> ERROR HANDLING >>> HyracksDataException now extends IOException. In VXQuery >>> SystemException extends HyracksDataException. This means we have some >>> various changes with respect to which exception to throw or catch. I >>> could use a second pair of eyes to verify my update is handling >>> exceptions correctly. **Help Point 1** >>> In addition the exception changes now cause the test suite to fail on >>> tests that are supposed to find a SystemException error code. **Help >>> Point 2** >>> >>> HDFS TESTING >>> To test HDFS we use a class class called MiniDFS. For some reason, the >>> class is no longer included in our packages. We need to find it and >>> include it. **Help Point 3** >>> >>> INDEXING UPDATE >>> Due to the changes to UTF8StringPointable many of the places where we >>> had previously hard coded a string length to be 2 bytes needs to be >>> changed. Indexing does not currently work because of these issues. >>> **Help Point 4** >>> >>> JSON UPDATE >>> Due to the changes to UTF8StringPointable many of the places where we >>> had previously hard coded a string length to be 2 bytes needs to be >>> changed. JSONiq has a few issues because of these changes. **Help >>> Point 5** >>> >>> I would appreciate some support (or at least some feedback) on fixing >>> the first three points. The last two points needs someone who will >>> actually test and write some code. >>> >>> Thanks >>> Preston >>> >>> [1] https://github.com/apache/vxquery/pull/166 >>> >>> On Tue, Apr 11, 2017 at 6:55 PM, Till Westmann <[email protected]> wrote: >>>> >>>> The current release version for AsterixDB is 0.9.0. I think that for >>>> some reason that tag didn’t make it to the GitHub mirror. Also the >>>> Hyracks 0.3.1 release is in progress. Unfortunately, I haven’t >>>> recently looked what it would take to update, but I think that it >>>> would be really good to do it … >>>> >>>> Cheers, >>>> Till >>>> >>>> On 11 Apr 2017, at 18:08, Preston Carman wrote: >>>> >>>>> Has anyone looked at what it would take to update VXQuery to the >>>>> latest version of Hyracks? It seems the project has had a few releases >>>>> since joining Apache. >>>>> >>>>> VXQuery Hyracks version: 0.2.17-incubating >>>>> Current Hyracks version: 0.3.X >>>>> >>>>> Also, do you know what is the current release version? The project >>>>> website says 0.9 for AsterixDB, but I am not sure about the Hyracks >>>>> sub-project. The github mirror only shows branches with release >>>>> versions up to 0.8.9.
