Hi Folks, For the comments from Gabor, I created the issue [ https://issues.apache.org/jira/browse/WAYANG-40] and the changes are on the branch develop [https://github.com/apache/incubator-wayang/tree/develop]
If you have any comments or questions please let me know. Thanks Gabor for pointing out this issue :D Best regards, Bertty On Thu, Sep 9, 2021 at 4:36 PM Bertty Contreras <[email protected]> wrote: > I will do that changes on the develop branch, give a couples of minutes > and I will do it :D > > On Thu, Sep 9, 2021 at 4:34 PM Gábor Gévay <[email protected]> wrote: > >> Hi Bertty, >> >> Oh, that would be great! Thank you! >> >> Best, >> Gábor >> >> >> >> >> Bertty Contreras <[email protected]> ezt írta (időpont: 2021. szept. >> 9., Cs, 16:31): >> > >> > Hi Gabor, >> > >> > It think is better to change the version of the spark rather than >> exclude >> > spark, we can use the version 2.4.x when the profile is scala-11 and the >> > version 3.1.2 when the profile scala-12 is activated. >> > What do you think? I can do it if you want. >> > >> > Best regards, >> > Bertty >> > >> > On Thu, Sep 9, 2021 at 4:29 PM Gábor E. Gévay <[email protected]> >> wrote: >> > >> > > I've realized in the meantime that many other Wayang modules are also >> > > using Spark. So I guess it's not enough to simply skip the >> > > wayang-spark module, sorry. I'm not sure what to do then. Maybe then >> > > Wayang has to drop support for Scala 2.11. >> > > >> > > Best, >> > > Gábor >> > > >> > > >> > > Gábor E. Gévay <[email protected]> ezt írta (időpont: 2021. szept. >> 9., >> > > Cs, 15:40): >> > > > >> > > > Hello, >> > > > >> > > > I’m exploring ways to integrate Emma into Wayang, but I ran into >> some >> > > issues. >> > > > >> > > > Emma can be compiled only with Scala 2.11, and it seems that >> > > > unfortunately I cannot upgrade it to Scala 2.12. So, my first >> question >> > > > is that is there an intention for Wayang to support Scala 2.11? If >> > > > not, then the Emma integration seems hopeless. >> > > > >> > > > So now I'm trying to compile Wayang with Scala 2.11. From the main >> > > > pom.xml, it seems that if I don’t specify any maven profile then it >> > > > should use Scala 2.11. In this case (‘mvn clean install’ without any >> > > > profiles), I’m running into 2 issues: >> > > > >> > > > 1. There is still the license problem with the Scala 2.11 compiler. >> I >> > > > think this can be fixed by simply adding 'BSD 3-Clause' to the >> allowed >> > > > licenses. (‘BSD 3-clause’ is already there, i.e., the same with a >> > > > different capitalization.) >> > > > >> > > > 2. Wayang uses Spark 3.1.2, which is not compatible with Scala 2.11. >> > > > For this, the only workaround I can think of is to include the >> > > > wayang-spark module only if the scala-12 profile is active, >> similarly >> > > > to how wayang-graphchi is active only if the scala-11 profile is >> > > > active. Do you think this would make sense? >> > > > >> > > > I did both of the above changes on the following branch: >> > > > https://github.com/ggevay/incubator-wayang/tree/spark-2.11 >> > > > If we would like Wayang to support Scala 2.11, then I could open a >> > > > pull request with this. >> > > > >> > > > Best, >> > > > Gábor >> > > >> >
