Hi all, I think I didn't express myself correctly when I told you not do discuss things in the VOTE thread. Usually you post your findings in the VOTE thread, but you don't start a discussion ... this way every email in the vote thread should contain a vote or a vote-change ... discussions would in contrast not contain votes, just discussion.
Sorry for being a bit uncleear, but I hope you get the idea. Ok here the feedback to my findings in the VOTE thread: - For the invalid location and naming, you don't need to cut a new release, you could simply move and rename the artifacts in SVN, however given the number of other finding, I would suggest to fix all of them and create a RC2: To see how it should be named, have a look at the other fellow podlings: https://dist.apache.org/repos/dist/dev/incubator/age/0.4.0.rc0/ - The binary font file with the commercial license needs to be removed or replaced by one with a compatible licensing. - If you rename the NOTICE.txt and the LICENSE.txt to NOTICE and LICENSE, everything should be ok. - The README tells me to edit the pom.xml to reference the right spark.version, however it seems as if I need to select at least one of the scala profiles: scala-11, 12 or 13 - You are using a variable "scala.mayor.version" ... are you sure this shouldn't be scala.major.version? Or does Scala have multiple Mayors? - The readme doesn't reference needing to have a HADOOP_HOME variable set or having Hadoop at all. - Even with Java 11 it seems some test fail in the spark module -----Ursprüngliche Nachricht----- Von: Christofer Dutz <[email protected]> Gesendet: Mittwoch, 29. September 2021 11:49 An: [email protected] Betreff: AW: [DISCUSS] Apache Wayang 0.6.0 RC1 Well the log says: Detected OS: mac Detected Arch: x86_64 Detecting Java version: 17 OK 17 FAILED (required max 11 but got 17) So the problem is, that you tried to build it with java 17 and the max supported version is set to Java 11. I wouldn’t say it’s an error. Chris Von: Alexander Alten <[email protected]> Gesendet: Mittwoch, 29. September 2021 09:44 An: [email protected] Betreff: Re: [DISCUSS] Apache Wayang 0.6.0 RC1 Heya, Build fails on M1 Macs - we should note this in our readme: Clean Mac: brew install maven scala groovy Download openJDK for M1: https://www.azul.com/downloads/?version=java-11-lts&os=macos&architecture=arm-64-bit&package=jdk (Since no official JDK for M1 is released) scala --version Scala code runner version 2.13.6 -- Copyright 2002-2021, LAMP/EPFL and Lightbend, Inc. java --version openjdk 11.0.12 2021-07-20 LTS OpenJDK Runtime Environment Zulu11.50+19-CA (build 11.0.12+7-LTS) OpenJDK 64-Bit Server VM Zulu11.50+19-CA (build 11.0.12+7-LTS, mixed mode) groovy --version Groovy Version: 3.0.9 JVM: 17 Vendor: Homebrew OS: Mac OS X mvn clean install -Pscala-13 [ERROR] Failed to execute goal org.codehaus.gmaven:groovy-maven-plugin:2.1.1:execute (prerequisite-check) on project wayang: Execution prerequisite-check of goal org.codehaus.gmaven:groovy-maven-plugin:2.1.1:execute failed: Not all conditions met, see log for details. -> [Help 1] [ERROR] Log attached - I’m not sure why the build fails on M1, Intel Mac works. So I bet on something in the deps which is not ARM ready yet. If so, we need to add this to our docs. Cheers, —Alex On 28. Sep 2021, at 22:12, Christofer Dutz <[email protected]<mailto:[email protected]>> wrote: Hi Gabor, the maven build would have succeeded, if wayang had been released. Right now there's no 0.6.0 available in maven-central. You could have added a repositories reference to https://repository.apache.org/content/repositories/orgapachewayang-1002 Then it problably would have worked. Will do my validation hopefully tomorrow. Chris -----Ursprüngliche Nachricht----- Von: Gábor E. Gévay <[email protected]<mailto:[email protected]>> Gesendet: Dienstag, 28. September 2021 20:05 An: [email protected]<mailto:[email protected]> Betreff: Re: [DISCUSS] Apache Wayang 0.6.0 RC1 Hello, Successfully compiled with `mvn clean install` with both -Pscala-11 on Java 8 and -Pscala-12 on Java 11. Verified the key and verified the sha checksum. I also tried creating an empty Maven project, adding Wayang as a dependency as described on our documentation page (https://wayang.apache.org/documentation/ ), and it worked after resolving a minor issue: The documentation page lists a number of dependencies that the user should add, and one of these is `wayang-api`, but this was not working for me. So this is what I had in my pom: <dependency> <groupId>org.apache.wayang</groupId> <artifactId>wayang-api</artifactId> <version>0.6.0</version> </dependency> And Maven gave the following error: [ERROR] Failed to execute goal on project wayang-proba: Could not resolve dependencies for project org.example:wayang-proba:jar:1.0-SNAPSHOT: Could not find artifact org.apache.wayang:wayang-api:jar:0.6.0 in central (https://repo.maven.apache.org/maven2) -> [Help 1] Changing `wayang-api` to `wayang-api-scala-java_2.11` works. Maybe `wayang-api` was left there from an older version? In that case, we could just update the website. Another minor thing about the documentation page is that it still says “If you need to rebuild Apache Wayang, e.g., to use a different Scala version, you can simply do so via Maven: Adapt the version variables (e.g., spark.version) in the main pom.xml file. ...” But this recently changed to the Maven profile stuff. But these would be just website changes, so I guess it doesn’t affect the release itself. So I gave +1 in the other thread. Best, Gábor
