Hi Betty, Thanks for addressing the issues so quickly. I am expecting that the issues I saß having, to be related with unpacking the release archive.
Chris Holen Sie sich Outlook für Android<https://aka.ms/AAb9ysg> ________________________________ From: Bertty Contreras <[email protected]> Sent: Tuesday, October 19, 2021 4:25:35 AM To: [email protected] <[email protected]> Subject: Re: [DISCUSS] Apache Wayang 0.6.0 RC3 Hi Folks, I updated the repository (https://github.com/apache/incubator-wayang main branch) - Ulysses issue: the archivo was deleted and I added a sintextic file to perform the tests - symlinks issue: the symlinks were deleted and now wayang just use the maven directory structure. - Hadoop instructions: the hadoop instructions added - update the plugin of scala because the old version throws an exception at compilation time. - the code was compiled and tested with Java 8 and Java 11 in windows, and run without issues (mvn clean install) - the version was returned from 0.6.1-Snapshot to 0.6.0-Snapshot - the module `wayang-distro` was deleted because it will not be useful from now on. - apache rat output: == File: ./.gitignore == File: ./wayang-benchmark/README.md == File: ./wayang-benchmark/code/test/resources/kmeans-k4-10000.input == File: ./wayang-commons/wayang-basic/src/test/resources/text.input == File: ./wayang-commons/wayang-core/src/test/resources/empty-plugin.yaml == File: ./wayang-commons/wayang-core/src/test/resources/partial-plugin.yaml == File: ./wayang-commons/wayang-core/src/test/resources/test-plugin.yaml == File: ./wayang-commons/wayang-utils-profile-db/README.md == File: ./wayang-docs/src/main/resources/Gemfile.lock == File: ./wayang-docs/src/main/resources/README.md == File: ./wayang-platforms/wayang-giraph/src/test/resources/test.edgelist.input == File: ./wayang-platforms/wayang-graphchi/src/test/resources/test.edgelist.input == File: ./wayang-tests-integration/code/test/resources/lines-with-key1.input == File: ./wayang-tests-integration/code/test/resources/lines-with-key2.input == File: ./wayang-tests-integration/code/test/resources/other-lines.input == File: ./wayang-tests-integration/code/test/resources/some-lines.input == File: ./wayang-tests-integration/code/test/resources/text.input and now the unique missing license file are the input for the tests. Let me know if I miss something. If you found some typo, please feel free to correct it :D Best regards, Bertty On Mon, Oct 18, 2021 at 9:34 PM Bertty Contreras <[email protected]> wrote: > I installed the windows 10 in a VM and was not having problem to clone > > git clone -c core.symlinks=true https://github.com/apache/incubator-wayang > > I add the flag "-c core.symlinks=true" because in windows by default is > false, that it may originating the issues, but I will update the code to > maven directory structure. > > and I take a look about the windows after I do the modification using the > maven directory structure, to see if something is broken. > > Best regards, > Bertty > > On Mon, Oct 18, 2021 at 6:55 PM Christofer Dutz <[email protected]> > wrote: > >> I think for this sort of thing, there probably should be enough >> license-free test-data out there that's safe to use ... I just happened to >> know that exactly this text has caused trouble in the past. >> >> And regarding the build problems ... I saw that you're not using a >> brand-new feature of maven, that I was unaware of ... you're using symlinks >> in your codebase ... that explains why it works on Linux and Mac and is >> causing problems on my Windows system. >> >> I would strongly suggest to not use symlinks. >> Because: >> 1) They cause problems like mine ... not sure how symlinks survive being >> sent in archives >> 2) They can cause issues like: I'm editing something in Spark 2.11, >> because it's fixing something there, but I'm breaking 2.12 without knowing >> why (I didn't change anything in the 2.12 module). >> 3) Calculating code-coverage starts getting messy >> >> I would suggest to instead use the source directory settings in maven to >> directly point to the source. >> >> https://www.codetab.org/tutorial/apache-maven/plugins/manage-maven-directories/ >> >> Chris >> >> >> >> -----Ursprüngliche Nachricht----- >> Von: Bertty Contreras <[email protected]> >> Gesendet: Montag, 18. Oktober 2021 18:36 >> An: [email protected] >> Betreff: Re: [DISCUSS] Apache Wayang 0.6.0 RC3 >> >> Hello Folks, >> >> I will change the file, because we just need a text to do a word count, I >> think I will create a dummy file with just words to avoid issues with >> licenses. >> >> About the windows, I'm downloading the ISO to create a virtual machine to >> figure the errors, and see well what is going on. >> >> Best regards, >> Bertty >> >> On Mon, Oct 18, 2021 at 6:09 PM Alexander Alten <[email protected]> wrote: >> >> > Heya Chris, >> > >> > Thanks for finding! >> > @bertty, do we need Ulysses in the release? >> > >> > Re: Windows 10 - I’d say we file a Jira and see if we get a need from >> > the community. Until than we flag the release with no support for >> Windows 10. >> > Thoughts? >> > >> > Cheers, >> > —Alex >> > >> > > On 18. Oct 2021, at 14:23, Christofer Dutz >> > > <[email protected]> >> > wrote: >> > > >> > > Hi All, >> > > >> > > so I had to vote -1 on the release ... I would have probably voted >> > > +1 if >> > there hadn't been a version of Ulysses added to the codebase. This is >> > a very old document, however in the EU this is already expired, except >> > for Spain, where it will be expired next year. The problem is that in >> > the US ist's still not expired till 2030. So we generally can't just >> let that pass. >> > > >> > > Please be sure to check the license of stuff you copy. I know this >> > > might >> > be important, but as you can see ... this little file will block your >> > release. >> > > >> > > Also did I notice, that building no longer works on Windows. On the >> > > one >> > side RAT on windows works slightly different ... at least it reports >> > things not reported on Linux (like the "scala", "resources" and "java" >> > files which contain paths). But if I tell rat to ignore them, I still >> > can't build as plugins are complaining that these files are not >> > directories (Which sort of makes sense). >> > > >> > > If windows is intentionally not a target system, this should be >> > mentioned prominently (Ideally the build should fail, telling the user >> > that Windows is not supported). If it's supported, it should build on >> Windows. >> > > >> > > Sorry fort he bad news :( >> > > >> > > Chris >> > > >> > > -----Ursprüngliche Nachricht----- >> > > Von: jorge Arnulfo Quiané Ruiz <[email protected]> >> > > Gesendet: Freitag, 15. Oktober 2021 15:44 >> > > An: [email protected] >> > > Betreff: Re: [DISCUSS] Apache Wayang 0.6.0 RC3 >> > > >> > > Hello everyone, >> > > >> > > Everything looks ok and I compiled the code without issues in both >> > > Java >> > 8 and Java 11. >> > > >> > > Best, >> > > Jorge >> > > >> > > On Fri, Oct 15, 2021 at 2:29 PM Rodrigo Pardo Meza < >> > [email protected]> >> > > wrote: >> > > >> > >> Hello Folks, >> > >> >> > >> I check the signatures, and modifications that Chris recommended in >> > >> the RC1 and it looks like everything it's ok. >> > >> >> > >> The code compiles without any issue in Java 8 and Java 11. >> > >> >> > >> @Alex you need to check if everything runs well on the ARM processor. >> > >> >> > >> I think this release is well done this time. >> > >> >> > >> By the way, Alex, I merge your pull request :D >> > >> >> > >> Best regards, >> > >> Rodrigo >> > >> >> > >> El vie, 15 oct 2021 a las 9:34, Alexander Alten >> > >> (<[email protected]>) >> > >> escribió: >> > >> >> > >>> Heya Bertty, >> > >>> >> > >>> Thanks! >> > >>> Just fixed some typos in the release notes via PR. >> > >>> >> > >>> Cheers, >> > >>> —Alex >> > >>> >> > >>>> On 15. Oct 2021, at 01:53, Bertty Contreras <[email protected]> >> > >> wrote: >> > >>>> >> > >>>> Hello people >> > >>>> >> > >>>> Please, any questions or concerns about the current release >> > >>>> candidate >> > >> can >> > >>>> be discussed here in this thread. So the VOTE thread stays clean. >> > >>>> >> > >>>> Otherwise, it is often difficult to see how people voted. >> > >>>> >> > >>>> Thanks in advance. >> > >>>> >> > >>>> Sincerely! >> > >>> >> > >>> >> > >> >> > >> > >> >
