Hello, That would be great; after the changes the notice seems to be ok plus the page rank example has been updated avoiding the issue.
Seems fine to me. Best regards El jue, 28 oct 2021 a las 17:11, Christofer Dutz (<[email protected]>) escribió: > Perhaps we should ask Justin to have a look if his issues have been dealt > with. > > Chris > > > -----Ursprüngliche Nachricht----- > Von: Alexander Alten <[email protected]> > Gesendet: Donnerstag, 28. Oktober 2021 16:37 > An: [email protected] > Betreff: Re: PRE-RELEASE > > Nope, does not looking good. Build passes only when PR35 is merged - a > NOTICE does not have to have .md - that causes license issues with rat. > > Local branch (with merged 35) build successful, both Java8 and 11. Since > we removed PageRank from Wikipedia I think we are good after the merge. > > Cheers, > —Alex > > > On 28. Oct 2021, at 15:22, jorge Arnulfo Quiané Ruiz < > [email protected]> wrote: > > > > Hello guys, > > > > I checked the list and everything looks good from my side. I am thus > > for starting the RC5. > > > > Thanks for the great job team! > > Jorge > > > > On Wed, Oct 27, 2021 at 2:58 PM Bertty Contreras <[email protected]> > > wrote: > > > >> Hello Folks, > >> > >> I did the modification on the code mentioned by Justin. > >> > >> Please double check the list and let me know if something is missing > >> or wrong. > >> > >> After you check I will perform RC5. > >> > >> All the code is on https://github.com/apache/incubator-wayang in the > >> main branch :D > >> > >> Best regards, > >> Bertty > >> > >
